Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[music][video] Context menu play items: Set playlist_type_hint before… #23478

Merged

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Jul 4, 2023

… starting playback, not after.

Fixes just a small stupid mistake I made when I was introducing the code. The property needs to be set before the playback is started to have any effect, not afterwards.

Runtime-tested on macOS and Android, latest Kodi master.

@enen92 something you can review?

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: Music Component: Video v21 Omega labels Jul 4, 2023
@ksooo ksooo added this to the Omega 21.0 Alpha 3 milestone Jul 4, 2023
@ksooo ksooo requested a review from enen92 July 4, 2023 15:27
@ksooo ksooo requested a review from DaveTBlake as a code owner July 4, 2023 15:27
@ksooo ksooo removed the request for review from DaveTBlake July 4, 2023 18:24
@enen92 enen92 merged commit caacf14 into xbmc:master Jul 4, 2023
2 checks passed
@ksooo ksooo deleted the video-audio-fix-playlisttypehint-property branch July 5, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants