Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[estuary] cinemavision => preshowexperience #23556

Closed
wants to merge 1 commit into from

Conversation

howie-f
Copy link
Contributor

@howie-f howie-f commented Jul 27, 2023

Description

noticed that skin estuary has some basic support for script.cinemavision. though its possible successor script.preshowexperience is not in the official repository (yet), i think it is safe to do this change so it won't get lost.

looks like @gade01 has already done this in skin.rapier gade01/Rapier@9a0c4ef

Motivation and context

had some play with script.preshowexperience

How has this been tested?

played cinema at home including stupid commercials (McDonalds and Langnese, a must have in german cinemas) audio- and ratingsbumpers etc.

What is the effect on users?

brings back a little cinema add-on support for estuary

Types of change

  • Clean up (non-breaking change which removes non-working, unmaintained functionality)

Checklist:

@howie-f howie-f added Type: Improvement non-breaking change which improves existing functionality Component: Skin v21 Omega labels Jul 27, 2023
@howie-f howie-f added this to the Omega 21.0 Alpha 3 milestone Jul 27, 2023
@howie-f howie-f requested a review from gade01 July 27, 2023 14:41
@gade01
Copy link
Contributor

gade01 commented Jul 27, 2023

Yeah, a lot of people requested the change for Rapier.
I think it makes sense as script.cinemavision is not maintained and developed anymore.

Although script.preahowexperience is not in the official repo and needs to be installed manually from zip, I think it's only a matter of time before it's submitted.

@fuzzard
Copy link
Contributor

fuzzard commented Aug 5, 2023

Had some confirmation this won't be merged unless the addon is submitted and accepted to the kodi repo

@fuzzard fuzzard added the Don't merge PR that should not be merged (yet) label Aug 5, 2023
@fuzzard fuzzard removed the v21 Omega label Oct 26, 2023
@howie-f howie-f closed this May 4, 2024
@howie-f howie-f deleted the v21-cinemavision branch May 4, 2024 17:35
@howie-f howie-f restored the v21-cinemavision branch May 4, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Skin Don't merge PR that should not be merged (yet) Type: Improvement non-breaking change which improves existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants