[macOS] Nuke XBMCHelper #23580
Draft
[macOS] Nuke XBMCHelper #23580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enen92
added
Type: Cleanup
14 tasks
jenkins4kodi
added
the
Rebase needed
jenkins4kodi
added
Rebase needed
enen92
force-pushed
the
nuke_xbmchelper
branch
from
c3ea377
to
5546e42
Compare
jenkins4kodi
removed
the
Rebase needed
jenkins4kodi
added
the
Rebase needed
|
@enen92 this needs a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
XBMCHelper is a little tool that allows Kodi to be controller via old Apple Remotes (those that date back the Siri remote - using the builtin infrared receiver https://en.wikipedia.org/wiki/Apple_Remote). It includes other stuff like a builtin Launch Agent and the companion event server remote.
The last mac models featuring the IR receiver (and the companion apple remote) are the MacBook Pro mid 2012 model and the mac mini mid 2012. The last macOS version allowed to run on such equipment is Mojave (10.14), precisely the minimum version required to run Kodi Omega.
Since it's not a good policy to simply drop stuff that might still be supported and usable (and used?), I propose to drop this once the macOS minimum requirement is bumped - rendering the last devices featuring the IR remote obsolete for Kodi. I honestly doubt we still have any users using such equipment for Kodi but you never know - this might even be easily (or already) supported in peripheral.joystick - I don't have any hardware to confirm.
Recent macs need some external usb IR receivers to still use those remotes (plus the required adaptation software - e.g. flirc) so this doesn't really make sense for recent macs (especially those with apple silicon).
Motivation and context
Cleanup
What is the effect on users?
Hopefully none, Kodi must support macOS > 10.14 when this is merged.