Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nexus][video] Fix default select action #23598

Merged
merged 2 commits into from Aug 8, 2023
Merged

[Nexus][video] Fix default select action #23598

merged 2 commits into from Aug 8, 2023

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Aug 8, 2023

Backport of #23594

@enen92 good to go in? Both commits are just cherry-picks from master.

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: Video Type: Backport v20 Nexus labels Aug 8, 2023
@ksooo ksooo added this to the Nexus 20.3 milestone Aug 8, 2023
@ksooo ksooo requested a review from enen92 August 8, 2023 12:42
enen92
enen92 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, as long as you continue to provide fixups I'd say it's fine
Not sure if there will be another nexus release though, regardless doesn't hurt to merge

@ksooo ksooo merged commit 34d2cac into xbmc:Nexus Aug 8, 2023
2 checks passed
@ksooo ksooo deleted the video-fix-default-select-action branch August 8, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enen92 enen92 enen92 approved these changes

Assignees
No one assigned
Labels
Component: Video Type: Backport Type: Fix non-breaking change which fixes an issue v20 Nexus
Projects
None yet
Milestone
Nexus 20.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ksooo @enen92