[Windows] Extend high precision setting to use 10 bit or better for all streams #23617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrystalP
added
Type: Improvement
thexai
approved these changes
Aug 13, 2023
thexai
reviewed
Aug 13, 2023
| // - trying VSR scaling, which requires RGB8 processor output format | ||
| // - the user opted out of high quality and the swap chain is 8 bits. | ||
| if (!m_tryVSR && (DX::Windowing()->IsHighPrecisionProcessingSettingEnabled() || | ||
| DX::Windowing()->GetBackBuffer().GetFormat() != DXGI_FORMAT_B8G8R8A8_UNORM)) |
There was a problem hiding this comment.
Suggested change
| DX::Windowing()->GetBackBuffer().GetFormat() != DXGI_FORMAT_B8G8R8A8_UNORM)) | |
| DX::Windowing()->GetBackBuffer().GetFormat() == DXGI_FORMAT_R10G10B10A2_UNORM)) |
CrystalP
force-pushed
the
extend-highprecision
branch
from
bcd3d6c
to
591b92e
Compare
|
Removed the unnecessary parameters in pixel shaders and dxva. |
thexai
reviewed
Aug 13, 2023
| const ProcessorConversion chosenConversion = | ||
| ChooseConversion(conversions, picture.colorBits, picture.color_transfer); | ||
| m_intermediateTargetFormat = chosenConversion.m_outputFormat; | ||
| const ProcessorConversion chosenConversion = ChooseConversion(conversions); |
There was a problem hiding this comment.
Suggested change
| const ProcessorConversion chosenConversion = ChooseConversion(conversions); | |
| m_conversion = ChooseConversion(conversions); |
| @@ -55,13 +55,10 @@ class CRendererDXVA : public CRendererHQ | |||
| * \param tryVSR yes/no favor a conversion that enables Video Super Resolution scaling | |||
| * \return | |||
| */ | |||
| DXVA::ProcessorConversion ChooseConversion(const DXVA::ProcessorConversions& conversions, | |||
…ll streams 8 bit YUV converted to RGB cannot be represented exactly with 8 bits so use 10 bits or float when the setting is enabled. Keep VSR exception.
CrystalP
force-pushed
the
extend-highprecision
branch
from
591b92e
to
df31f74
Compare
…ks thexai for noticing.
CrystalP
force-pushed
the
extend-highprecision
branch
from
df31f74
to
2da7159
Compare
afedchin
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified
CRendererDXVA::ChooseConversionandCRendererShaders::CalcIntermediateTargetFormatthat select the intermediate target format for dxva and pixel shaders render method.The exception of using 8 bits for VSR was preserved.
Even the case of 8 bit stream going to 8 bit backbuffer should benefit a bit, since there is scaling, optional LUT and dithering after the color conversion. Extra cost, if any, should be minimal (cheap bit shifting to go 8 bit <=> 10 bits, probably built in gpu and free)
It could be special cased and excluded though, but complex to detect when there is no post-processing after color conversion.
This removes the need to change the same functions to remove duplication of tests that distinguish SDR from HDR (ex PR #23599)
Motivation and context
Found out after a bit of research that the conversion of 8 bit YUV to RGB is not exact with 8 bits destination texture, justifying the use of 10 bits.
How has this been tested?
Windows 10 with sdr, hdr streams, some that activate VSR => 8 bit and 10 bit backbuffers.
What is the effect on users?
Slightly improved precision for SDR streams.
Types of change
Checklist: