[macOS][nativewindowing] Event location only makes sense for mouse ev…

[enen92]

…ents

Description

Currently we are ignoring any events if the location does not have a window bound to the event or even if the event coordinates are negative. This happens when, for example, the mouse is outside of the window bounds or when triggering keypresses with the mouse outside of the window...

Apart from calculating the location for any kind of event that doesn't necessarily need it (waste of resources), we are also ignoring other kind of events. For example, media keys (systemdefined) do not trigger the respective event (wip). Keypresses are only interpreted if the mouse is within the window...that also doesn't make sense and affects the user experience.

@kambala-decapitator it'd be nice if you could have a quick look. I'd like to have this in alpha3

[kambala-decapitator]

btw on the mouse topic: I've noticed that mouse cursor receives the big Kodi-style shape only after I move the cursor outside the fullscreen window and move it back. I observe the following:

1. start Kodi with 2 screens, it opens on the second screen correctly
2. move mouse inside Kodi - it has hardware cursor shape
3. move the cursor outside the fullscreen window and move it back - it eceives the big Kodi-style shape
4. e.g. move cursor to the top to reveal OS menubar - it turns to hardware shape again, moving it down inside Kodi doesn't change shape. 3) helps to restore cursor size again.

[enen92]

btw on the mouse topic: I've noticed that mouse cursor receives the big Kodi-style shape only after I move the cursor outside the fullscreen window and move it back. I observe the following:

1. start Kodi with 2 screens, it opens on the second screen correctly
2. move mouse inside Kodi - it has hardware cursor shape
3. move the cursor outside the fullscreen window and move it back - it eceives the big Kodi-style shape
4. e.g. move cursor to the top to reveal OS menubar - it turns to hardware shape again, moving it down inside Kodi doesn't change shape. 3) helps to restore cursor size again.

I'll give a go but I never noticed this. Running macOS ventura right?

[kambala-decapitator]

Running macOS ventura right?

yep

[enen92]

Running macOS ventura right?

yep

Yeap can't reproduce unfortunately. Maybe this only happens on x86 or something (i'll keep it in mind to give it a spin with my old mac on the beginning of next month)

[enen92]

Actually I could reproduce now - but for this to happen another app on another screen must be focused (e.g. click somewhere on xcode). I'll look into a fix when possible (outside of this PR though).

edit: fixed in #23659

[kambala-decapitator]

didn't notice any issues with this PR in runtime test