[video] Unify code paths for 'show video information' … #23674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent behavior. Optimize and modernize code a bit.
ksooo
added
Type: Cleanup
enen92
approved these changes
Aug 28, 2023
14 tasks
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to gain consistent behavior. Optimize and modernize code a bit.
Existing code to open the video information dialog is kinda unstructured (it grew in an organic manner over time, I'd say.). This PR tries to unify and simplify the different code paths. No functional changes intended, just refactoring for better maintainability.
Runtime-tested on macOS and Android, latest Kodi master.
@enen92 can you please take a look...