Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small simplifications #23740

Merged
merged 4 commits into from Sep 10, 2023
Merged

Conversation

notspiff
Copy link
Contributor

@notspiff notspiff commented Sep 9, 2023

Description

Just some code cleanup

  • switch instead of if nests
  • maps instead of if nests
  • table instead of duplicated string formatting statements

Motivation and context

I was bored in the sun and figured I'd do some coding.

How has this been tested?

Buttons work in skins, search works in library.

What is the effect on users?

None

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@notspiff notspiff added Type: Improvement non-breaking change which improves existing functionality Component: Music Component: Video v22 "P" labels Sep 9, 2023
@notspiff notspiff added this to the "P" 22.0 Alpha 1 milestone Sep 9, 2023
@enen92
Copy link
Member

enen92 commented Sep 9, 2023

@notspiff why only for v22?

@notspiff
Copy link
Contributor Author

notspiff commented Sep 9, 2023 via email

@enen92
Copy link
Member

enen92 commented Sep 9, 2023

Uhm no real reason, just used to selecring last milestone when there is no real value in a backport. But i guess omega is not forked yet then..

Afaik we usually only branch when reaching release candidate. We're still on the way to Beta 1 so I think it's fine to get it in earlier :)
But, your call :)

@notspiff notspiff merged commit c8e8334 into xbmc:master Sep 10, 2023
2 checks passed
@notspiff notspiff deleted the small_simplifications branch September 10, 2023 15:13
@fuzzard fuzzard added v21 Omega and removed v22 "P" labels Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Music Component: Video Type: Improvement non-breaking change which improves existing functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants