Fixup warnings macos #23756
Merged
Fixup warnings macos #23756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enen92
added
Type: Improvement
|
@enen92 Can you update the description to point to the PRs that introduced the warnings? By easily seeing which milestones those PRs targeted it would help me maintain my retroplayer branch based on the Alpha 3 release. |
|
@garbear done |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes two new warnings introduced with my recent PRs which is leading the quality gate to fail.
One include was incorrectly named, and one of the variables on the tests was unused.
I'll merge this if jenkins is green, no need to bother anyone with a review.
Regressions introduced in #23741 and #23724 respectively