Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] windows remove superfluous installdata #23853

Merged
merged 1 commit into from Oct 2, 2023

Conversation

fuzzard
Copy link
Contributor

@fuzzard fuzzard commented Oct 2, 2023

Description

Remove superfluous installdata for windows desktop platform

Motivation and context

Stumbled across this working on some other cmake packaging. These items are already added in cmake/installdata/common/addons.txt. This would just be leftovers from a time forgotten. The actual binary parts for these two addons are installed into project/BuildDependencies/${ARCH}/bin/Python/Lib/site-packages/* as part of the prebuilt dependency download steps.

How has this been tested?

Build windows, 2 x addons are still packaged

What is the effect on users?

N/A

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@fuzzard fuzzard added this to the Omega 21.0 Beta 1 milestone Oct 2, 2023
@garbear garbear added the Type: Cleanup non-breaking change which removes non-working or unmaintained functionality label Oct 2, 2023
Copy link
Member

@garbear garbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe

@fuzzard fuzzard merged commit 3568059 into xbmc:master Oct 2, 2023
2 checks passed
@fuzzard fuzzard deleted the cmake_wininstalldata_cleanup branch October 2, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants