[settings][video][PVR][listproviders][favourites] Add default play action setting. #23863

ksooo · 2023-10-03T14:46:17Z

Adds a new setting for defining what happens when "play" action is executed, similar to what we already have for the "select" action.

Currently, despite from behaving differently at different places throughout Kodi, you cannot control whether playback will automatically resume if possible or if user shall be asked whether to start over or resume. We have complaints in the Forum, that users find it annoying to always being asked, they want automatic resume, others stated exactly the opposite. This feels like we need a setting. :-)

With this PR, behavior will be consistent throughout video windows, pvr recordings window, favourites window and listprovider lists (aka home screen widgets) ... and user-customizable via the new setting.

Runtime-tested on macOS and Android, latest Kodi master.

@enen92 be my guest for a review, best done commit-by-commit.

ksooo · 2023-10-04T05:58:31Z

Fixes #23868

the-black-eagle · 2023-10-04T06:10:13Z

Might just be me but I would like an option to "choose" whether to resume or re-start. However, if you decide not to implement that, this is still much better than what we have currently 👍

ksooo · 2023-10-04T06:34:12Z

Might just be me but I would like an option to "choose" whether to resume or re-start.

If the setting is set to "play" and you select something with a resume point, it will present a small context menu asking whether to resume or start from the beginning. If no resume point, there is nothing to "choose", thus no dialog, straight playback.

If the setting is set to "resume", then the playback will automatically resumed if possible or playback automatically starts from beginning, no user choice here, as no options.

The help text for the setting actually explains the behavior.

the-black-eagle · 2023-10-04T08:18:39Z

it will present a small context menu asking whether to resume or start from the beginning

Brilliant! Thanks.

addons/resource.language.en_gb/resources/strings.po

enen92 · 2023-10-04T09:45:49Z

xbmc/favourites/GUIWindowFavourites.cpp

@@ -117,6 +118,25 @@ class CVideoSelectActionProcessor : public VIDEO::GUILIB::CVideoSelectActionProc
    return true;
  }
 };
+
+class CVideoPlayActionProcessor : public VIDEO::GUILIB::CVideoPlayActionProcessorBase


I'll have to implement something like this for discs too

Good point. I was already of the opinion that I may have missed some places where we also kick off video playback action. :-) Maybe we can do this in a follow-up PR?

Sure, it's a bit involved when coming to discs since it's tangled together in builtins

CAutorun::RunDisc it is maybe.

Yeah but the autorun itself also doesn't make sense (it's a poll approach from the CApp itself)...
Long story short, don't worry about this.

Long story short, don't worry about this.

With pleasure. Had a quick look at the code and it felt like another can of worms. I think for Omega I already have refactored enough old code.

xbmc/favourites/GUIWindowFavourites.cpp

xbmc/listproviders/DirectoryProvider.cpp

Hitcher · 2023-10-04T13:03:05Z

Personally I think it should be 3 options -

Ask
Play
Resume

This way everything is covered.

jjd-uk · 2023-10-04T13:25:02Z

Personally I think it should be 3 options -

Ask

Play

Resume

This way everything is covered.

To me that would be the ideal except I'd have

Choose (default - have the pop up only if this is selected)
Play (if you always want to auto-playback from start)
Resume

However if that means having to touch far more code than you wanted I could live with:

Play or Choose
Resume

ksooo · 2023-10-04T15:31:35Z

@jjd-uk @HitcherUK thanks for the feedback. We will go with

msgid "Default play action"
msgid "Ask if resumable"
msgid "Resume"

... and explain in the help text the fallback to play from beginning.

ksooo · 2023-10-04T15:32:20Z

@enen92 requested/discussed code and string changes are in now. Good to go in?

enen92

Looks good! Thanks
I added a small nitpick which I think reads better on the help text.

addons/resource.language.en_gb/resources/strings.po

…ing.

…n setting.

…on setting.

Hitcher · 2023-10-07T12:14:38Z

Is this still a WIP because there's no 'Always play' option?

ksooo · 2023-10-07T13:59:08Z

Is this still a WIP because there's no 'Always play' option?

No WIP. I do not plan to add "Always play" because I cannot see the need for this. Who would want to always ignore any resume points for all videos?

the-black-eagle · 2023-10-07T15:00:26Z

Who would want to always ignore any resume points for all videos?

All I would say is, I think its preferable to have options of

Always do A
Always do B
Ask should I do A or B

Otherwise users either always get asked (resume point exists) or video just resumes. I guess there is plenty of stuff I once started watching where I wouldn't want to resume as I no longer remember what happened. Getting asked each time could become tedious I guess, especially if I don't remember what might have a resume point.

Just my POV. I'm not pushing for changes, just pointing out what I think users might want/think.

ksooo · 2023-10-07T15:36:42Z

I guess there is plenty of stuff I once started watching where I wouldn't want to resume as I no longer remember what happened.

"Always play" means you forget always everything, thus you never want to resume.

From formal stand point I see what you mean with 3 options being best to have, looking at what users really can make use of, I doubt that "Always play" will actually used by anybody.

Hitcher · 2023-10-07T18:22:43Z

Sorry, I thought from your initial post you meant some users always want to resume and others always want to play.

Hitcher · 2023-10-08T08:39:51Z

If there's no actual play option for a Default Play Action setting, maybe it should be renamed Default Resume Action, as this setting only affects what happens when there's a resume point.

ksooo · 2023-10-08T09:02:56Z

We discussed this, and decided to go with default play. You can read this up on the discussion in this PR.

ksooo added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Improvement non-breaking change which improves existing functionality Component: PVR Component: Video Component: Settings v21 Omega Component: Favourites labels Oct 3, 2023

ksooo added this to the Omega 21.0 Beta 1 milestone Oct 3, 2023

ksooo requested a review from enen92 October 3, 2023 14:46

ksooo force-pushed the video-play-actions branch from e4906f8 to 1e0fa70 Compare October 3, 2023 16:34

enen92 changed the title ~~[settings][video][PVR][lictproviders][favourites] Add default play action setting.~~ [settings][video][PVR][listproviders][favourites] Add default play action setting. Oct 3, 2023

ksooo force-pushed the video-play-actions branch from 1e0fa70 to 0d01e7b Compare October 3, 2023 20:59

ksooo mentioned this pull request Oct 4, 2023

Folder items in widgets are playing/queueing instead of opening folder. #23868

Closed

7 tasks

ksooo force-pushed the video-play-actions branch from 0d01e7b to 3aa541d Compare October 4, 2023 06:07

enen92 reviewed Oct 4, 2023

View reviewed changes

addons/resource.language.en_gb/resources/strings.po Outdated Show resolved Hide resolved

enen92 reviewed Oct 4, 2023

View reviewed changes

xbmc/favourites/GUIWindowFavourites.cpp Outdated Show resolved Hide resolved

enen92 reviewed Oct 4, 2023

View reviewed changes

xbmc/listproviders/DirectoryProvider.cpp Outdated Show resolved Hide resolved

ksooo force-pushed the video-play-actions branch from 3aa541d to fe3478b Compare October 4, 2023 15:29

enen92 approved these changes Oct 4, 2023

View reviewed changes

addons/resource.language.en_gb/resources/strings.po Outdated Show resolved Hide resolved

ksooo added 2 commits October 4, 2023 18:42

[video][settings] Add default play action setting.

a3f6447

[video] CGUIWindowVideoBase: Add support for default play action sett…

9f536cd

…ing.

ksooo added 3 commits October 4, 2023 18:42

[PVR] CGUIWindowPVRRecordingsBase: Add support for default play actio…

dc8a6e8

…n setting.

[favourites] CGUIWindowFavourites: Add support for default play actio…

5087071

…n setting.

[listproviders] CDirectoryProvider: Add support for default play acti…

dd4f5d6

…on setting.

ksooo force-pushed the video-play-actions branch from fe3478b to dd4f5d6 Compare October 4, 2023 18:00

ksooo merged commit 0f28947 into xbmc:master Oct 4, 2023
2 checks passed

ksooo deleted the video-play-actions branch October 4, 2023 19:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[settings][video][PVR][listproviders][favourites] Add default play action setting. #23863

[settings][video][PVR][listproviders][favourites] Add default play action setting. #23863

ksooo commented Oct 3, 2023 •

edited

ksooo commented Oct 4, 2023

the-black-eagle commented Oct 4, 2023

ksooo commented Oct 4, 2023 •

edited

the-black-eagle commented Oct 4, 2023

enen92 Oct 4, 2023

ksooo Oct 4, 2023

enen92 Oct 4, 2023

ksooo Oct 4, 2023

enen92 Oct 4, 2023

ksooo Oct 4, 2023

Hitcher commented Oct 4, 2023 •

edited

jjd-uk commented Oct 4, 2023 •

edited

ksooo commented Oct 4, 2023

ksooo commented Oct 4, 2023

enen92 left a comment

Hitcher commented Oct 7, 2023

ksooo commented Oct 7, 2023

the-black-eagle commented Oct 7, 2023

ksooo commented Oct 7, 2023

Hitcher commented Oct 7, 2023

Hitcher commented Oct 8, 2023 •

edited

ksooo commented Oct 8, 2023

[settings][video][PVR][listproviders][favourites] Add default play action setting. #23863

[settings][video][PVR][listproviders][favourites] Add default play action setting. #23863

Conversation

ksooo commented Oct 3, 2023 • edited

ksooo commented Oct 4, 2023

the-black-eagle commented Oct 4, 2023

ksooo commented Oct 4, 2023 • edited

the-black-eagle commented Oct 4, 2023

enen92 Oct 4, 2023

Choose a reason for hiding this comment

ksooo Oct 4, 2023

Choose a reason for hiding this comment

enen92 Oct 4, 2023

Choose a reason for hiding this comment

ksooo Oct 4, 2023

Choose a reason for hiding this comment

enen92 Oct 4, 2023

Choose a reason for hiding this comment

ksooo Oct 4, 2023

Choose a reason for hiding this comment

Hitcher commented Oct 4, 2023 • edited

jjd-uk commented Oct 4, 2023 • edited

ksooo commented Oct 4, 2023

ksooo commented Oct 4, 2023

enen92 left a comment

Choose a reason for hiding this comment

Hitcher commented Oct 7, 2023

ksooo commented Oct 7, 2023

the-black-eagle commented Oct 7, 2023

ksooo commented Oct 7, 2023

Hitcher commented Oct 7, 2023

Hitcher commented Oct 8, 2023 • edited

ksooo commented Oct 8, 2023

ksooo commented Oct 3, 2023 •

edited

ksooo commented Oct 4, 2023 •

edited

Hitcher commented Oct 4, 2023 •

edited

jjd-uk commented Oct 4, 2023 •

edited

Hitcher commented Oct 8, 2023 •

edited