[favourites] Fix CFavouritesService::IsFavourited to only compare man… #23885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
enen92
reviewed
Oct 7, 2023
enen92
approved these changes
Oct 7, 2023
ksooo
force-pushed
the
favourites-fix-add-remove
branch
3 times, most recently
from
98fe0e7
to
43931ee
Compare
…favourites, although already added.
ksooo
force-pushed
the
favourites-fix-add-remove
branch
from
43931ee
to
cd61b3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…datory parts of the favourites URLs.
Fixes a (long standing?) bug with items already added to favourites not recognized as such, resulting in context menu item "Add to favourites" offered for them, instead of "Remove from favourites".
How to reproduce:
0) Go to Estuary Home screen, Movies section
=> Bug: "Add to favourites" will be offered, not "Remove from favourites"
Runtime-tested on macOS and Android, latest Kodi master.
@enen92 please review.