Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing c++ headers #23920

Merged
merged 1 commit into from Oct 14, 2023
Merged

add missing c++ headers #23920

merged 1 commit into from Oct 14, 2023

Conversation

mlauss2
Copy link
Contributor

@mlauss2 mlauss2 commented Oct 13, 2023

Add a few missing headers which are no longer indirectly included by other headers, fixes build with gcc-14

Description

Fix build with gcc-14: add a few missing includes which are no longer included implicitly through
other headers.

Motivation and context

Fix building kodi with gcc-14, mainly due to template errors about std::find() and friends, which are
fixed by including the <algorithm> header.

How has this been tested?

Build kodi-gbm on linux x86_64 with gcc version 14.0.0 20231012 (experimental) 701363d827d45d3e3601735fa42f95644fda8b64

What is the effect on users?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Add a few missing headers which are no longer indirectly included by
other headers, fixes build with gcc-14
@mlauss2 mlauss2 requested a review from lrusak as a code owner October 13, 2023 10:30
@Rechi Rechi added Type: Fix non-breaking change which fixes an issue v21 Omega labels Oct 13, 2023
@Rechi Rechi added this to the Omega 21.0 Beta 1 milestone Oct 13, 2023
@enen92 enen92 merged commit d4c1fcd into xbmc:master Oct 14, 2023
2 checks passed
@mlauss2 mlauss2 deleted the gcc14-fix branch October 19, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants