[GUI] [Skins] Bump skins backwards-compatibility abi to 5.17.0 #23927
Conversation
jjd-uk
changed the title
|
@ronie if you have any time then your input would be appreciated. |
|
Repo at present If both xbmc.gui and abi were immediately bumped this would results in no skins option as there would be no compatible skins in the repo.
So as I thought, it's probably best to merge #23926 first then wait a bit for skins to update their xbmc.gui version to 5.17.0 |
jjd-uk
changed the title
|
Looking at the 9 skins we have in the Nexus repo it looks like 5 of them might only require a simple version bump as they have DialogColorPicker.xml and MyFavourites.xml these are Aeon Nox Silvo, Aeon Tajo, Arctic Zephry mod, Bello 9 & Tetradui. The other 4 are missing either DialogColorPicker.xml or MyFavourites.xml: Copacetic & Rapier are missing MyFavourites.xml Metropolis & Quartz are missing both DialogColorPicker.xml and MyFavourites.xml |
jenkins4kodi
added
the
Rebase needed
|
@jjd-uk this needs a rebase |
jjd-uk
force-pushed
the
bump_skins_abi
branch
from
002b005
to
9fe1ab8
Compare
|
Since #23926 didn't make in in time for Beta 1, we need to wait until after Beta 2 for this to merge Otherwise we get stuck in no-man's land: Skins can't bump their GUI version to 5.17 at the moment because users on Beta 1 won't be able to use the skin. But if the ABI bump goes in before Beta 2, then users on nightlies won't be able to use the skin either. |
jjd-uk
removed
the
Rebase needed
|
Since this was raised Video Versions has gone in meaning a new Omega only Dialog that users will need to use the feature. So another reason for doing this. |
|
@fuzzard seems you got the message from what was said on Slack. So for the benefit of anyone else looking in. As API bump #23926 missed Beta 1 and was done in early Beta 2, the agreed strategy would apprear to be:
This is following the comment from @jurialmunkey above and a comment from @ronie on Slack that we should NOT do both the API & ABI bumps within Beta 2. |
|
A quick thought I had on this when updating my own repo in anticipation: Was there a Kodi version bump that went in around the same time as GUI bump? Would be useful to know what that is to set |
|
Sorry @jurialmunkey I have no idea. |
Description
Break backwards-compatibility for skins by bumping to 5.17.0
#23926 MUST go in first.
This is done seperately from the xbmc.gui bump, as bumping this immediately with the xbmc.gui bump will render all skins no longer compatible with Omega until they have bumped their xbmc.gui version to 5.17.0, so as a result I'm unsure when this should go in. Perhaps wait until RC to give skins some time to bump to 5.17.0???
Raising this now even if not wanted immediately so it's not forgotten as something in my view that MUST be done before final release of Omega to ensure skin compatibility.
Motivation and context
Last ABI version bump was in #18082 meaning Matrix skins are still compatible with both Nexus and Omega up to now.
However since the last bump to the ABI there has been several things that could cause feature breakage in skins, the ones I'm aware of are:
New DialogColorPicker.xml introduced in Nexus by [Subtitles] Implemented new subtitle features #20169 and without this new dialog skins installed onto Nexus & Omega can't set subtitle colour or subtitle border colour so these core setting options will be broken.
If the changes in Nexus to SettingsScreenCalibration.xml necessitated by [gui] Implemented movingspeed to mover/resize controls #21364 haven't been done then the screen calibration window will be broken.
Removal of DialogFavourites.xml in Omega by [favourites] Remove CGUIDialogFavourites. #23862 so the new MyFavourites.xml (introduced in Nexus [favourites][estuary] Add Favourites window. #22001) must be used.
In addition for Games
How has this been tested?
Runtime tested on Windows