Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Visual Studio warnings #23976

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix Visual Studio warnings #23976

merged 1 commit into from
Oct 23, 2023

Conversation

thexai
Copy link
Member

@thexai thexai commented Oct 21, 2023

Description

Fix Visual Studio warnings

Motivation and context

18:11:11 C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.34.31933\include\memory(3433,56): warning C4244: 'argument': conversion from '_Ty' to 'float', possible loss of data [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]
18:11:11           with
18:11:11           [
18:11:11               _Ty=int
18:11:11           ] (compiling source file C:\jenkins-workspace\workspace\WIN-64\xbmc\rendering\RenderSystem.cpp)
18:11:11 C:\jenkins-workspace\workspace\WIN-64\xbmc\rendering\RenderSystem.cpp(70,1): message : see reference to function template instantiation 'std::unique_ptr<CGUIImage,std::default_delete<CGUIImage>> std::make_unique<CGUIImage,int,int,int,int,int,int,CTextureInfo,0>(int &&,int &&,int &&,int &&,int &&,int &&,CTextureInfo &&)' being compiled [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]
18:11:28 C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.34.31933\include\memory(3433,56): warning C4244: 'argument': conversion from '_Ty' to 'float', possible loss of data [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]
18:11:28           with
18:11:28           [
18:11:28               _Ty=int
18:11:28           ] (compiling source file C:\jenkins-workspace\workspace\WIN-64\xbmc\windows\GUIWindowSplash.cpp)
18:11:28 C:\jenkins-workspace\workspace\WIN-64\xbmc\windows\GUIWindowSplash.cpp(34,1): message : see reference to function template instantiation 'std::unique_ptr<CGUIImage,std::default_delete<CGUIImage>> std::make_unique<CGUIImage,int,int,int,int,int,int,CTextureInfo,0>(int &&,int &&,int &&,int &&,int &&,int &&,CTextureInfo &&)' being compiled [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]

How has this been tested?

Build Windows x64

What is the effect on users?

none

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@thexai thexai added Type: Fix non-breaking change which fixes an issue v21 Omega labels Oct 21, 2023
@thexai thexai added this to the Omega 21.0 Beta 2 milestone Oct 21, 2023
@thexai
Copy link
Member Author

thexai commented Oct 23, 2023

Jenkins build and merge

@thexai thexai merged commit fa75603 into xbmc:master Oct 23, 2023
2 checks passed
@thexai thexai deleted the fix-warnings branch October 23, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants