Add window InGameSaves #24034
Closed
Add window InGameSaves #24034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enen92
reviewed
Oct 31, 2023
| @@ -139,6 +139,7 @@ This page shows the window names, the window definition, the window ID and the s | |||
| | StartWindow | WINDOW_START | 12998 | shortcut to the current startwindow | | | |||
| | Startup | WINDOW_STARTUP_ANIM | 12999 | Startup.xml | | | |||
| | FavouritesBrowser | WINDOW_FAVOURITES | 10060 | MyFavourites.xml | @skinning_v20 **New window** FavouritesBrowser, replaces the old Favourites dialog.<p></p> | | |||
| | InGameSaves | WINDOW_DIALOG_IN_GAME_SAVES | 10829 | DialogSelect.xml | | | |||
There was a problem hiding this comment.
Can you check out when it was introduced in Kodi? maybe in v20 too?
|
Are we missing any of these? https://github.com/xbmc/xbmc/blob/master/xbmc/guilib/WindowIDs.h#L147-L158 |
Add missing game windows
scott967
force-pushed
the
Doxygen_fix_Ingamesaves
branch
from
8472403
to
4d06d79
Compare
|
OK did further review and force pushed updated commit. Not sure how the changes should be documented, but these are the applicable PRs: #20505 GamePorts v20 I added these windows in WindowID order. Not sure how to annotate the PRs/impacted versions |
garbear
added
Type: Fix
|
@scott967 Thanks for bringing up in slack that some other game doxy was missing too. I'll send a PR and take care of these window IDs, as well as the new controls and features added in both v20 and v21. |
|
Done: #24033 |
8 tasks
|
Superseded by #24055 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add windows GameSaves/InGameSaves/GamePorts/GameAgents to guilib/WindowIds.dox
Motivation and context
missing in doxygen documentation Separately logged as issue for tracking
#24033
How has this been tested?
not tested
What is the effect on users?
No user impact / developer only
Screenshots (if appropriate):
Types of change
Checklist: