Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VideoVersion] Added VideoVersionPlay dialog #24132

Merged
merged 1 commit into from Nov 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
41 changes: 41 additions & 0 deletions addons/resource.language.en_gb/resources/strings.po
Expand Up @@ -23790,21 +23790,25 @@ msgctxt "#40009"
msgid "Found a different version of {0:s} \"{1:s}\" ({2:s}). Would you like to convert it into an additional version of the original?"
msgstr ""

#. "video version" string in singular format
#: xbmc/media/MediaType.cpp
msgctxt "#40010"
msgid "video version"
msgstr ""

#. "video version" string in plural format
#: xbmc/media/MediaType.cpp
msgctxt "#40011"
msgid "video versions"
msgstr ""

#. "video version" string in singular capital format
#: xbmc/media/MediaType.cpp
msgctxt "#40012"
msgid "Video version"
msgstr ""

#. "video version" string in plural capital format
#: xbmc/media/MediaType.cpp
msgctxt "#40013"
msgid "Video versions"
Expand Down Expand Up @@ -23920,186 +23924,223 @@ msgstr ""

# Video versions

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40400"
msgid "Standard Edition"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40401"
msgid "Extended Edition"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40402"
msgid "Unrated Version"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40403"
msgid "Uncut Version"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40404"
msgid "Remastered Version"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40405"
msgid "4K"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40406"
msgid "Theatrical Cut"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40407"
msgid "Director's Cut"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40408"
msgid "Special Edition"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40409"
msgid "Limited Edition"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40410"
msgid "Complete Edition"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40411"
msgid "The Final Cut"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40412"
msgid "Super Duper Cut"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40413"
msgid "Collector's Edition"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40414"
msgid "Ultimate Collector's Edition"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40415"
msgid "Criterion Collection Edition"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40416"
msgid "Fan Edit"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40417"
msgid "Black and White Edition"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40418"
msgid "BluRay"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40419"
msgid "WEB-DL"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40420"
msgid "3D"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40421"
msgid "8K"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40422"
msgid "IMAX"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40423"
msgid "UHD"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40424"
msgid "FHD"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40425"
msgid "HD"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40426"
msgid "SD"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40427"
msgid "DVD"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40428"
msgid "VHS"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40429"
msgid "VCD"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40430"
msgid "REMUX"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40431"
msgid "10th Anniversary Edition"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40432"
msgid "20th Anniversary Edition"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40433"
msgid "25th Anniversary Edition"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40434"
msgid "30th Anniversary Edition"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40435"
msgid "40th Anniversary Edition"
msgstr ""

#. Name of a video version, like "Director's Cut"
#: xbmc/video/VideoDatabase.cpp
msgctxt "#40436"
msgid "50th Anniversary Edition"
Expand Down
4 changes: 3 additions & 1 deletion xbmc/guilib/GUIWindowManager.cpp
Expand Up @@ -292,7 +292,8 @@ void CGUIWindowManager::CreateWindows()
Add(new CGUIDialogMusicInfo);
Add(new CGUIDialogOK);
Add(new CGUIDialogVideoInfo);
Add(new CGUIDialogVideoVersion);
Add(new CGUIDialogVideoVersion(WINDOW_DIALOG_VIDEO_VERSION));
Add(new CGUIDialogVideoVersion(WINDOW_DIALOG_VIDEO_VERSION_PLAY));
Add(new CGUIDialogTextViewer);
Add(new CGUIWindowFullScreen);
Add(new CGUIWindowVisualisation);
Expand Down Expand Up @@ -334,6 +335,7 @@ bool CGUIWindowManager::DestroyWindows()
DestroyWindow(WINDOW_DIALOG_MUSIC_INFO);
DestroyWindow(WINDOW_DIALOG_VIDEO_INFO);
DestroyWindow(WINDOW_DIALOG_VIDEO_VERSION);
DestroyWindow(WINDOW_DIALOG_VIDEO_VERSION_PLAY);
DestroyWindow(WINDOW_VIDEO_PLAYLIST);
DestroyWindow(WINDOW_VIDEO_NAV);
DestroyWindow(WINDOW_FILES);
Expand Down
1 change: 1 addition & 0 deletions xbmc/guilib/WindowIDs.dox
Expand Up @@ -134,6 +134,7 @@ This page shows the window names, the window definition, the window ID and the s
| Visualisation | WINDOW_VISUALISATION | 12006 | MusicVisualisation.xml | |
| Slideshow | WINDOW_SLIDESHOW | 12007 | SlideShow.xml | |
| DialogColorPicker | WINDOW_DIALOG_COLOR_PICKER | 12008 | DialogColorPicker.xml | |
| VideoVersionPlay | WINDOW_DIALOG_VIDEO_VERSION_PLAY | 12009 | DialogVideoVersion.xml | @skinning_v21 **New window** VideoVersionPlay |
| Weather | WINDOW_WEATHER | 12600 | MyWeather.xml | |
| Screensaver | WINDOW_SCREENSAVER | 12900 | none | |
| VideoOSD | WINDOW_DIALOG_VIDEO_OSD | 12901 | VideoOSD.xml | |
Expand Down
1 change: 1 addition & 0 deletions xbmc/guilib/WindowIDs.h
Expand Up @@ -169,6 +169,7 @@
#define WINDOW_VISUALISATION 12006
#define WINDOW_SLIDESHOW 12007
#define WINDOW_DIALOG_COLOR_PICKER 12008
#define WINDOW_DIALOG_VIDEO_VERSION_PLAY 12009
#define WINDOW_WEATHER 12600
#define WINDOW_SCREENSAVER 12900
#define WINDOW_DIALOG_VIDEO_OSD 12901
Expand Down
1 change: 1 addition & 0 deletions xbmc/input/WindowTranslator.cpp
Expand Up @@ -120,6 +120,7 @@ const CWindowTranslator::WindowMapByName CWindowTranslator::WindowMappingByName
{"okdialog", WINDOW_DIALOG_OK},
{"movieinformation", WINDOW_DIALOG_VIDEO_INFO},
{"videoversion", WINDOW_DIALOG_VIDEO_VERSION},
{"videoversionplay", WINDOW_DIALOG_VIDEO_VERSION_PLAY},
{"textviewer", WINDOW_DIALOG_TEXT_VIEWER},
{"fullscreenvideo", WINDOW_FULLSCREEN_VIDEO},
{"dialogcolorpicker", WINDOW_DIALOG_COLOR_PICKER},
Expand Down
6 changes: 3 additions & 3 deletions xbmc/video/dialogs/GUIDialogVideoVersion.cpp
Expand Up @@ -68,8 +68,8 @@ static constexpr unsigned int CONTROL_BUTTON_CHOOSE_ART = 27;
static constexpr unsigned int CONTROL_LIST_PRIMARY_VERSION = 50;
static constexpr unsigned int CONTROL_LIST_EXTRAS_VERSION = 51;

CGUIDialogVideoVersion::CGUIDialogVideoVersion()
: CGUIDialog(WINDOW_DIALOG_VIDEO_VERSION, "DialogVideoVersion.xml"),
CGUIDialogVideoVersion::CGUIDialogVideoVersion(int id)
: CGUIDialog(id, "DialogVideoVersion.xml"),
m_videoItem(std::make_shared<CFileItem>()),
m_primaryVideoVersionList(std::make_unique<CFileItemList>()),
m_extrasVideoVersionList(std::make_unique<CFileItemList>()),
Expand Down Expand Up @@ -663,7 +663,7 @@ void CGUIDialogVideoVersion::PlayVideoVersion(const std::shared_ptr<CFileItem>&
// prompt to play selected video version
CGUIDialogVideoVersion* dialog =
CServiceBroker::GetGUI()->GetWindowManager().GetWindow<CGUIDialogVideoVersion>(
WINDOW_DIALOG_VIDEO_VERSION);
WINDOW_DIALOG_VIDEO_VERSION_PLAY);
if (!dialog)
return;

Expand Down
2 changes: 1 addition & 1 deletion xbmc/video/dialogs/GUIDialogVideoVersion.h
Expand Up @@ -22,7 +22,7 @@ class CVideoDatabase;
class CGUIDialogVideoVersion : public CGUIDialog
{
public:
CGUIDialogVideoVersion(void);
CGUIDialogVideoVersion(int id);
~CGUIDialogVideoVersion(void) override;
bool OnMessage(CGUIMessage& message) override;
void SetVideoItem(const std::shared_ptr<CFileItem>& item, bool playMode);
Expand Down