Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDL] Migrate to tinyxml2 #24185

Merged
merged 2 commits into from Dec 5, 2023
Merged

[EDL] Migrate to tinyxml2 #24185

merged 2 commits into from Dec 5, 2023

Conversation

enen92
Copy link
Member

@enen92 enen92 commented Dec 5, 2023

Description

Snapcast BeyondTV uses a XML format for EDL markers. Move the usage to tinyxml2.
While at it I've ditched the hungarian notation too (I won't be changing any other stuff).
We have unit tests for this so as long as they pass we are fine.

@enen92 enen92 added Type: Improvement non-breaking change which improves existing functionality Component: Players For changed player parts within "./xbmc/cores" v21 Omega labels Dec 5, 2023
@enen92 enen92 added this to the Omega 21.0 Beta 2 milestone Dec 5, 2023
@enen92 enen92 requested a review from fuzzard December 5, 2023 10:47
Copy link
Member

@garbear garbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a pretty direct conversion, and jenkins is green, so +1 from me.

@enen92 enen92 merged commit 7fe30de into xbmc:master Dec 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Players For changed player parts within "./xbmc/cores" Type: Improvement non-breaking change which improves existing functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants