[Estuary] Fix selected colours

[Hitcher]

Description

Fixes the selected colours in lists for the default and charcoal schemes.

Motivation and context

It wasn't obvious what the selected items were in lists for the default and charcoal colour schemes. This fixes both of them.

How has this been tested?

Tested locally.

What is the effect on users?

Screenshots (if appropriate):

Before (default):

Before (charcoal):

Comparison with brown:

After (default):

After (charcoal):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• Student submission (PR was done for educational purposes and will be treated as such)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[jjd-uk]

Much better.

[jurialmunkey]

Looks good to me. Also did a colour blindness filter check in GIMP and has good visibility in all three.

Possible side issue not for this PR but related, I noticed in FileBrowser that selectedcolor is hardcoded to green. Not sure why that is but I suspect should be changed for consistency.

xbmc/addons/skin.estuary/xml/FileBrowser.xml

Line 90 in ca903e2

<selectedcolor>green</selectedcolor>

[jjd-uk]

@HitcherUK the point made about hardcoded green in FileBrowser, I think that should be addressed. Can you do that? if so can you add here or would you prefer to do a separate PR?

[Hitcher]

I can add it to this PR as it covers 'selectedcolor'.

[Hitcher]

Added fix for file browser selected colour being green.

[garbear]

I like what I'm seeing in the screenshots!

[jjd-uk]

LGTM.

@HitcherUK @jurialmunkey Was looking to check out the FileBrowser change just to verify it picks up the default label selectedcolour however I can't find any instance where a selected item would actually be triggered, so not sure what that was even doing there at all in the first place. Am I missing some use case that might set a selected item? all I can if that is that it is used for browsing the file structure for example when adding a source, or browsing to find a subtitle.

[jurialmunkey]

Am I missing some use case that might set a selected item?

@jjd-uk - Dialog class has an enableMultiple boolean for browse function:
https://xbmc.github.io/docs.kodi.tv/master/kodi-base/d6/de8/group__python___dialog.html#ga3a3b4ef3f55a926aea5e81d7620a6174

I assume that's what select colour is used -- though I'm not sure if I've ever seen anything use it.

[jurialmunkey]

FYI Here's what the change looks like in FileBrowser with multiple selections: