Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Estuary] Make all views consistent with PR#24168 #24258

Merged
merged 2 commits into from
Dec 19, 2023
Merged

[Estuary] Make all views consistent with PR#24168 #24258

merged 2 commits into from
Dec 19, 2023

Conversation

Hitcher
Copy link
Contributor

@Hitcher Hitcher commented Dec 17, 2023

Description

Further improve visibility of overlays for more views in relation to #24168.

Motivation and context

Makes overlays consistent across different views as well as displaying more types of overlays (eg ListItem.IsPlaying, etc).

How has this been tested?

Tested locally.

What is the effect on users?

Screenshots (if appropriate):

screenshot00007

screenshot00008

screenshot00009

screenshot00010

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Hitcher Hitcher added Type: Improvement non-breaking change which improves existing functionality Component: Skin v21 Omega labels Dec 17, 2023
@Hitcher Hitcher added this to the Omega 21.0 Beta 3 milestone Dec 17, 2023
@Hitcher Hitcher self-assigned this Dec 17, 2023
addons/skin.estuary/xml/View_51_Poster.xml Outdated Show resolved Hide resolved
addons/skin.estuary/xml/View_53_Shift.xml Outdated Show resolved Hide resolved
addons/skin.estuary/xml/View_54_InfoWall.xml Outdated Show resolved Hide resolved
@jurialmunkey
Copy link

Also that issue I mentioned above looks to be present in the original PR.

@jjd-uk
Copy link
Member

jjd-uk commented Dec 17, 2023

Also that issue I mentioned above looks to be present in the original PR.

Yes that was fixed in #24217

@Hitcher
Copy link
Contributor Author

Hitcher commented Dec 17, 2023

Ah, I forgot about the fix. Will update.

Copy link
Member

@jjd-uk jjd-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjd-uk jjd-uk merged commit b1ba1a9 into xbmc:master Dec 19, 2023
1 check passed
@Hitcher Hitcher deleted the fix_poster_view branch December 19, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Skin Type: Improvement non-breaking change which improves existing functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants