Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] Disable video version scan #24279

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

jjd-uk
Copy link
Member

@jjd-uk jjd-uk commented Dec 20, 2023

Description

Disable the scanning of video versions and extras by default until a decision is taken what to do about the wider code.

Motivation and context

See #14972 (comment)

Screenshots (if appropriate):

Before
image

After
image

@jjd-uk jjd-uk requested review from fuzzard and ksooo December 20, 2023 08:53
@jjd-uk
Copy link
Member Author

jjd-uk commented Dec 20, 2023

Additionally these settings can be hidden by setting to Level 4 but didn't want to go that far at this time.

@jjd-uk jjd-uk added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Component: Settings v21 Omega labels Dec 20, 2023
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jjd-uk jjd-uk added this to the Omega 21.0 Beta 3 milestone Dec 20, 2023
@the-black-eagle
Copy link
Contributor

According to the help text, it doesn't disable the feature though. It just disables the pop-up ??

@jjd-uk
Copy link
Member Author

jjd-uk commented Dec 20, 2023

According to the help text, it doesn't disable the feature though. It just disables the pop-up ??

It doesn't disable the feature, but it will return scanning to previous default behaviour with creation of duplicates I think, as the creation of versions requires user interaction via the pop ups.

@the-black-eagle
Copy link
Contributor

All good then :)

@ksooo
Copy link
Member

ksooo commented Dec 20, 2023

Yeah, the technical name of the setting videolibrary.ignorevideoversions implies that the whole feature can be disabled by this, but this is not the case. IMO, the technical setting name should be changed to reflect what it actually controls. But this is for another PR.

@ksooo
Copy link
Member

ksooo commented Dec 20, 2023

And looking at the strings for the two related settings: They are inconsistent.

"Ignore different video versions on scan"
but no 'different' present for extras
"Ignore video extras on scan"

@ksooo ksooo merged commit 290a8e6 into xbmc:master Dec 20, 2023
1 check passed
@jjd-uk jjd-uk deleted the settings_video_versions branch January 3, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Settings Feature: Video Versions/Extras Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants