[video] Fix playback of multi-version movies. Do not prompt for versi…

[ksooo]

…on to play, as we already know it from the context of the info dialog.

Fixes #24322

In the context of the info dialog, we always display information for a certain version. No need to ask which one to play.

@jurialmunkey fyi

Runtime-tested on macOS, latest Kodi master.

@enen92 should be simple to review. We have an item property to control whether version chooser will be used.

[enen92]

Thanks much

[CrystalP]

Does what it says but maybe a bit premature, as versions are not independent movies (yet).

In the context of the info dialog, we always display information for a certain version. No need to ask which one to play.

Not in my tests. The information displayed is that of the "root" movie that versions were added to.
Versions can only have individual artwork at this point, but it is not used in the info dialog (tested by changing the poster from default on all versions of a movie).

[ksooo]

Does what it says but maybe a bit premature, as versions are not independent movies (yet).

Step by step, in small chunks, okay? Otherwise we end up with monster PRs. The fix is needed as of now. Everything else can be fixed separately. Logically the info dialog displays for a certain version already. There are bugs (e.g. artwork) and due to the broken data model no real metadata per version. But this is where we are heading to.

[ksooo]

Versions can only have individual artwork at this point, but it is not used in the info dialog (tested by changing the poster from default on all versions of a movie).

Please open an issue for the artwork problem.

[jurialmunkey]

I appreciate the quick fix. Behaviour is much improved.

I'm assuming a subsequent PR will change where select appears to make it consistent with how Action(Info) behaves? i.e.
Click movie > Opens default version info > Click play > Select version

Can see how this change sets up future possibilities for toggling whether info asks to select or shows default, so I'm not much fussed about the order itself, only the inconsistency between an info key press and select as info key press.

Very much low priority, but thought it worth mentioning. Can open a new issue for this if you'd like?

[ksooo]

Write an issue, please. So we don’t forget.