[video] Fix no video information available when playing strm files, … #24333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
enen92
reviewed
Dec 27, 2023
enen92
approved these changes
Dec 27, 2023
…lthough they were added to the video library.
ksooo
force-pushed
the
video-fix-strm-video-info
branch
from
8d78a00
to
59aa086
Compare
|
Jenkins build this please |
|
Unfortunately, I only saw the message today that I should open an issue. But you have already fixed the error 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…although they where added to the video library.
Fixes fallout from video versions feature playback adaptions.
Reported here: #24318 (comment) (no GH issue for this as of now)
First,
Application::PlayMedianeeds to load video info tag from database unconditional as it was done in Nexus, because for example there the video info for strm files is loaded if they where added to the video library.Second,
CGUIWindowVideoBasemust not callLoadPlayListfor stream files, as "the old way" (see existing code comment) simply does not work for strm files. This code path was not reached in Nexus, but in Omega, due to other changes that were done to make video versions selections and playback work.Runtime-tested on macOS, latest Kodi master.
@enen92 whenever you find some time for a review.