[video] Video Versions/Extras: More smaller cleanup and fixes

[ksooo]

Some smaller cleanups and fixes for Video Versions and Extras:

1) Movie window -> node "Versions" does now only show what it says, versions, no extras anymore.

Before:

After:

2) Fix: When playing an extra, the OSD contained the information of the movie the extra was attached to, which makes no sense, as the extra is not the movie itself. What is correct fpor versions, is not for extras.

3) Make the labels for video conversion more user friendly:

4) Swapped position of context menu item "Add as version to..." and "Manage versions". Now, "Manage movie sets" and "Manage versions" are located next to each other, followed by "Add as version to...". See screen shot above.

[enen92]

Looks good but if someone else could take a look into the dB changes it would be better

[CrystalP]

I know that I suggested "Add as version to..." but after thinking about it, it doesn't convey the idea that the movie will be removed from the movies list.

Alternative: "Convert to version of...". It implies that the current item will be transformed.
The difference with the current message is the addition of "of...", which I think clarifies things enough.

But I'll go with the consensus.

[atrugiel69]

I wrote this in the development discussion: https://forum.kodi.tv/showthread.php?tid=337992&pid=3177462#pid3177462

And it was written several days ago. Why is this proceeding with two different menu entries? I remain convinced it's unneeded and confusing for end users.

[ksooo]

And it was written several days ago. Why is this proceeding with two different menu entries? I remain convinced it's unneeded and confusing for end users.

@atrugiel69 I do agree, but I'm not in a position to decide this without having the okay from the team.

[CrystalP]

Technically both paths accomplish the same thing in the end.
It's a matter of personal preference and mindset. Start with the movie to attach (context menu), or with the movie to be attached to (manage dialog).

[da-anda]

I'm fine with dropping the additional context menu entry. So far I just found it at least a bit more straight forward than the manage dialog where you end up in a file browser instead of a movie list of your library (it's fine for extras, but unexpected for movies). If we think we could fix this behavior for Omega, then I'm more than fine to get rid of the second context menu entry. If we don't want to push RC another month just for the video versions, I might be in favor of keeping it, at least for Omega, and then ditch it in P* along with more improvements/refactoring. But no hard feelings either way.

PS: getting rid of the file browse dialog also will prevent a NAS from having to spin up just for converting library entries into versions