Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Peripherals] Fix missing controller icons in Peripheral Dialog #24384

Merged
merged 1 commit into from Jan 5, 2024

Conversation

garbear
Copy link
Member

@garbear garbear commented Jan 1, 2024

Description

Controller profiles were introduced for peripherals in #21182, and in #22856 it became possible to change a peripheral's appearance.

However, the appearance always depended on peripheral.joystick being used. On Android, the peripheral bus is in core instead of the add-on. As a result, peripheral icons aren't shown on Android.

This PR updates the peripheral bus base class to take icon into account, without needing the peripheral bus to be peripheral.joystick. As a result, peripheral icons are now shown on Android.

Motivation and context

Giving Android some love now that my NVidia Shield is working again.

How has this been tested?

Included in my latest round of test builds: https://github.com/garbear/xbmc/releases

What is the effect on users?

  • Fixed peripheral icons not shown in Peripheral Dialog on Android

Screenshots (if appropriate):

Before:

Screenshot_20231231-192412

After:

Screenshot_20231231-191332

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

@garbear garbear added this to the Omega 21.0 Beta 3 milestone Jan 1, 2024
@garbear
Copy link
Member Author

garbear commented Jan 2, 2024

I've simplified the change. Now it's only a single line difference.

@garbear
Copy link
Member Author

garbear commented Jan 5, 2024

jenkins build this please

@garbear garbear merged commit 49f1ade into xbmc:master Jan 5, 2024
2 checks passed
@garbear garbear deleted the fix-peripheral-icons branch January 5, 2024 19:00
@garbear garbear changed the title [Peripherals] Fix missing controller icon in Peripheral Dialog [Peripherals] Fix missing controller icons in Peripheral Dialog Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant