[Peripherals] Fix missing controller icons in Peripheral Dialog #24384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Controller profiles were introduced for peripherals in #21182, and in #22856 it became possible to change a peripheral's appearance.
However, the appearance always depended on peripheral.joystick being used. On Android, the peripheral bus is in core instead of the add-on. As a result, peripheral icons aren't shown on Android.
This PR updates the peripheral bus base class to take icon into account, without needing the peripheral bus to be peripheral.joystick. As a result, peripheral icons are now shown on Android.
Motivation and context
Giving Android some love now that my NVidia Shield is working again.
How has this been tested?
Included in my latest round of test builds: https://github.com/garbear/xbmc/releases
What is the effect on users?
Screenshots (if appropriate):
Before:
After:
Types of change