[gui] Move listproviders to guilib #24463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enen92
added
Type: Improvement
|
I've made some formatting changes to meet the current code style. The diffs are available in the following links: For more information please see our current code style guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the listproviders folder/submodule inside the guilib folder.
Motivation and context
Listproviders are completely on the scope of GUI (used by controls in skins). For general organization I find it easier to have all classes/components that are supposed to be gui related inside GUI folders. It's easier to create a map and understand the overall gui dependency footprint of a given component or class if we import "guilib/listproviders/" than simply "listproviders". For instance I initially thought
CDirectoryProviderhad no relation to GUI at all when it's just an implementation of a GUI list provider.No functional changes, just moving stuff around.
How has this been tested?
Compiled and runtime (as long as it compiles we should be fine)