Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joysticks] Fix broken focus on emulated analog stick #24513

Merged
merged 1 commit into from Jan 23, 2024

Conversation

garbear
Copy link
Member

@garbear garbear commented Jan 15, 2024

Description

This PR's a simple one. Clearly some old use case, in the 9 year history of this code, was causing the game to see input when it shouldn't. I added a few checks for input "acceptance", but it seems like I added one-to-many. It can't hurt for the game to not not get input, and it clearly breaks analog sticks in the screenshots below, so disable the check here.

Motivation and context

This check is called later on, so the redunant call here can cause input to be unnecessarily dropped.

How has this been tested?

Runtime tested on Windows and Ubuntu 22.04. Will include in test builds.

Screenshots (if appropriate):

Before: Actual peripheral is highlighted, but game port isn't getting activated.

Screenshot from 2024-01-15 01-01-48

After: Game port is successfully activated.

Screenshot from 2024-01-15 01-01-05

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

This check is called later on, so the redunant call here can cause input
to be unnecessarily dropped.
@garbear garbear added Type: Fix non-breaking change which fixes an issue Component: Input v21 Omega labels Jan 15, 2024
@garbear garbear added this to the Omega 21.0 Beta 3 milestone Jan 15, 2024
@garbear garbear merged commit acb1cc0 into xbmc:master Jan 23, 2024
2 checks passed
@garbear garbear deleted the fix-port-focus branch January 23, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Input Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant