[Joysticks] Fix broken focus on emulated analog stick #24513
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR's a simple one. Clearly some old use case, in the 9 year history of this code, was causing the game to see input when it shouldn't. I added a few checks for input "acceptance", but it seems like I added one-to-many. It can't hurt for the game to not not get input, and it clearly breaks analog sticks in the screenshots below, so disable the check here.
Motivation and context
This check is called later on, so the redunant call here can cause input to be unnecessarily dropped.
How has this been tested?
Runtime tested on Windows and Ubuntu 22.04. Will include in test builds.
Screenshots (if appropriate):
Before: Actual peripheral is highlighted, but game port isn't getting activated.
After: Game port is successfully activated.
Types of change