Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS: add missing key mappings #24556

Merged
merged 1 commit into from
Jan 21, 2024
Merged

MacOS: add missing key mappings #24556

merged 1 commit into from
Jan 21, 2024

Conversation

enen92
Copy link
Member

@enen92 enen92 commented Jan 21, 2024

Description

This adds a few missing NS* to XBMCK key mappings. A few more might still be missing but let's add them as they are actually requested.

Motivation and context

Fixes #24544 for omega/master. It looks like it was broken between 20.2 and 20.3 but I've really no interest to dig into it as we've replaced the windowing implementation altogether for v21.

How has this been tested?

Runtime tested with the keymap provided in the issue report

What is the effect on users?

Restore functionality for some edge cases - keymaps

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

@enen92 enen92 added Type: Fix non-breaking change which fixes an issue Platform: macOS v21 Omega labels Jan 21, 2024
@enen92 enen92 added this to the Omega 21.0 Beta 3 milestone Jan 21, 2024
@enen92 enen92 merged commit 677676e into xbmc:master Jan 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: macOS Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

20.3(Nexus) no longer map Function keys on macOS
2 participants