Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools/depends] Bump gettext 0.22.4 #24630

Merged
merged 2 commits into from Feb 10, 2024
Merged

Conversation

fuzzard
Copy link
Contributor

@fuzzard fuzzard commented Feb 3, 2024

Description

Bump gettext 0.22.4

Motivation and context

Cleanup. Updates to latest release. Allows us to remove the am_cv_func_iconv_works workaround, as it appears to now be functional in sonoma (fixed in 0.22.3)
Also testing to try and remove a patch (01-gettext-tools-stpncpy.patch) thats been around forever, and im not sure if its required anymore. Builds/runs ok on macos without, so jenkins will let me know android/linux failures hopefully.

How has this been tested?

Build/run macos aarch64

What is the effect on users?

N/A

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@fuzzard
Copy link
Contributor Author

fuzzard commented Feb 10, 2024

Jenkins build this please

Copy link
Contributor

@sundermann sundermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on webOS and macOS

@fuzzard fuzzard merged commit 54e9033 into xbmc:master Feb 10, 2024
2 checks passed
@fuzzard fuzzard deleted the depends_gettext_0.22.4 branch February 10, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants