Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video] fill GUIListItem properties with streamdetails for the hybrid… #24645

Merged
merged 1 commit into from Feb 6, 2024

Conversation

CrystalP
Copy link
Contributor

@CrystalP CrystalP commented Feb 4, 2024

Description

The videotag stream details are not copied into item properties for folders.

Added an exception for the special hybrid movie/folders representing parent movies when the "Show versions as folder" setting is turned on. The properties will be populated using the stream details of the default version.

To be removed in v22 with better handling of versions.

Motivation and context

Issue reported in the forum https://forum.kodi.tv/showthread.php?tid=337992&pid=3182306#pid3182306
Thanks @jjd-uk for the modified dialog to visualize the properties.

How has this been tested?

Regular folder, .. parent folder, movies without additional versions, movie sets, navigation from Versions node.

What is the effect on users?

Skins that use listitem.property to retrieve audio stream details will have receive the information of the default version.

Screenshots (if appropriate):

Before:
image

After:
image

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed in v22 with better handling of versions.

I agree.

Copy link
Member

@jjd-uk jjd-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say anything about the code but I've tested and it fixes the problem.

@CrystalP CrystalP merged commit ca059b3 into xbmc:master Feb 6, 2024
2 checks passed
@CrystalP CrystalP deleted the fix-parentmovie-properties branch February 6, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants