Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MUSIC] Allow navigating from artist directly to songs via AS.xml setting #24649

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

the-black-eagle
Copy link
Contributor

Description

As per the title, this allows users to skip navigating to albums from artists and goes directly to all the songs for an artist.
This works for any list of artists, so navigating via role -> composer -> artist -> songs also skips albums.

Motivation and context

Was requested or at least suggested on the forum https://forum.kodi.tv/showthread.php?tid=375313 by a team member. I can see how this is useful in some situations and at some point I think it's a candidate for the context menu, but not at the moment as that would be too invasive at this point.

How has this been tested?

Added the appropriate AS.xml setting and navigated through several screens of artists , composers, lyricists etc and in all cases, skipped the album node and navigated directly to songs.

What is the effect on users?

Users can choose to navigate from an artist directly to a list of songs, skipping the album / disc parts. This has to be enabled via AS.xml. Other navigation paths (album, boxsets, top 100 etc) are not affected by this.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@the-black-eagle the-black-eagle added Type: Feature non-breaking change which adds functionality Type: Improvement non-breaking change which improves existing functionality Wiki: Needed Component: Music v21 Omega labels Feb 5, 2024
@the-black-eagle the-black-eagle added this to the Omega 21.0 Beta 3 milestone Feb 5, 2024
@fuzzard fuzzard merged commit 85d0144 into xbmc:master Feb 10, 2024
2 checks passed
@the-black-eagle the-black-eagle deleted the artist_stuff branch February 11, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Music Type: Feature non-breaking change which adds functionality Type: Improvement non-breaking change which improves existing functionality v21 Omega Wiki: Needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants