Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] fall back to legacy OpenGL profile on NSOpenGLContext creation error #24822

Merged

Conversation

kambala-decapitator
Copy link
Contributor

Description

adjusts one attribute when creating NSOpenGLContext

Motivation and context

fixes #24811 - now post-Nexus is usable on old iGPUs again

How has this been tested?

launched Kodi on my MBP 2010 that's driven by iGPU running Ventura via OCLP

What is the effect on users?

users with ancient Macs on iGPU can use post-Nexus

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Btw I assume for the GPU the temperatures are also wrong right? Might need to add that to smctemp too

@kambala-decapitator
Copy link
Contributor Author

btw I assume for the GPU the temperatures are also wrong right?

yeah

@enen92
Copy link
Member

enen92 commented Mar 8, 2024

Note for the future: Please do not merge stuff without jenkins finishing the build

@kambala-decapitator
Copy link
Contributor Author

Note for the future: Please do not merge stuff without jenkins finishing the build

hmm, but it was green already? https://jenkins.kodi.tv/job/BuildMulti-PR/29551/

@enen92
Copy link
Member

enen92 commented Mar 8, 2024

Maybe some issue with GitHub, for some reason it was still showing as running. Disregard

enen92 added a commit that referenced this pull request Mar 9, 2024
[BP][macOS] fall back to legacy OpenGL profile on NSOpenGLContext creation error #24822
@kambala-decapitator kambala-decapitator deleted the macos-opengl-attrs branch March 9, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS][regression] Omega crashes on old iGPU
2 participants