Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL/GLES: Add anisotropic filtering support #24841

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

sarbes
Copy link
Member

@sarbes sarbes commented Mar 12, 2024

Description

The PR adds support for anisotropic filtering to GL/GLES.

It is an advanced setting for the time being:

<advancedsettings>
  <gui>
    <anisotropicfiltering>16</anisotropicfiltering>
  </gui>
</advancedsettings>

Motivation and context

Texture surfaces at glancing angles are a bit blurry (if sampled with mipmapping enabled) or display shimmering artifacts (without mm).

With Anisotropic filtering, the GPU might sample from multiple locations, giving a nicer looking result. The actual implementation is highly GPU dependent.

How has this been tested?

On my RX570, it has no effect with our current texture pipeline. Forcing mipmaps, there is some visible change on rotated surfaces.

What is the effect on users?

Higher image quality for X/Y rotated surfaces, with possible performance decrease.

Screenshots (if appropriate):

Forced mipmap:
mipmap

Forced mipmap + anisotropic filtering:
mipmap_aniso

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@sarbes sarbes added this to the "P" 22.0 Alpha 1 milestone Mar 12, 2024
@neo1973 neo1973 merged commit f0b18b5 into xbmc:master Apr 8, 2024
2 checks passed
@neo1973
Copy link
Member

neo1973 commented Apr 8, 2024

@sarbes: Please add the new settings to https://kodi.wiki/view/Advancedsettings.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants