Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VideoInfoScanner] Honor importwatchedstate and importresumepoint from AS.xml #24925

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neo1973
Copy link
Member

@neo1973 neo1973 commented Mar 31, 2024

Description

When importwatchedstate and/or importresumepoint are set to false in advancedsettings.xml they should not be imported from NFOs.

Motivation and context

Fixes #24909.

How has this been tested?

Using this dummy NFO:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<movie>
  <title>Die Hard</title>
  <originaltitle>Die Hard</originaltitle>
  <year>1988</year>
  <playcount>1</playcount>
  <resume>
    <position>15</position>
    <total>100</total>
  </resume>
</movie>

And then testing all combinations of importwatchedstate and importresumepoint.

What is the effect on users?

Users can again choose to not import watched state and resume point from NFOs.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@neo1973 neo1973 added Type: Fix non-breaking change which fixes an issue Backport: Needed v22 "P" labels Mar 31, 2024
@neo1973 neo1973 added this to the "P" 22.0 Alpha 1 milestone Mar 31, 2024
Copy link
Contributor

@CrystalP CrystalP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xbmc/video/VideoInfoScanner.cpp Outdated Show resolved Hide resolved
@Vislike
Copy link

Vislike commented Apr 3, 2024

Since i am curious about the problem i checked your commit. Your fix is in a function called "RetrieveInfoForMovie", do you think the same fix need to be applied to the other functions as well for this to also work for tv shows and so on? I have not looked into this in details, was just a thought.

@neo1973
Copy link
Member Author

neo1973 commented Apr 8, 2024

Good point, as is this only works for movies. I'll have to look into a better solution to cover other media types as well.

@neo1973 neo1973 added the Don't merge PR that should not be merged (yet) label Apr 8, 2024
@jenkins4kodi jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Apr 16, 2024
@jenkins4kodi
Copy link
Contributor

@neo1973 this needs a rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Needed Don't merge PR that should not be merged (yet) Rebase needed PR that does not apply/merge cleanly to current base branch Type: Fix non-breaking change which fixes an issue v22 "P"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

importwatchedstate ignored in advancedsettings.xml from Kodi 20.0
4 participants