-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webOS] Implement DTS support #24991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - makes sense, especially as it's needed for a Sink.
One thing to mention is that for DTS:X support we need to have this information available. This is available from ffmpeg 6.1 as a profile hint so I'll leave that for later. This also applies for the eAC3 JOC case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Core changes are minimal. The changes to other components outside of WebOS are simply member variable name changes. All good.
Just one more small change moved setting |
Jenkins build this please |
@sundermann I tested this yesterday and the DTS audio seems to have sync issues, which doesn't happen to me with AC3 passthrough. |
Nothing more we can do in the sink with the limited API we have available now. |
Description
Implement DTS support for webOS.
The dts packet frame size was not available from
AEStreamInfo
so I renamedm_ac3FrameSize
tom_frameSize
and added the necessary changes to theAEStreamParser
to expose that information. All the other sinks that use this field only use it in case of (e)AC3 audio so the change has no effect on them.Motivation and context
How has this been tested?
webOS 8, tried several different DTS format files
What is the effect on users?
Screenshots (if appropriate):
Types of change
Checklist: