Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webOS] Implement DTS support #24991

Merged
merged 1 commit into from
Apr 14, 2024
Merged

[webOS] Implement DTS support #24991

merged 1 commit into from
Apr 14, 2024

Conversation

sundermann
Copy link
Contributor

Description

Implement DTS support for webOS.

The dts packet frame size was not available from AEStreamInfo so I renamed m_ac3FrameSize to m_frameSize and added the necessary changes to the AEStreamParser to expose that information. All the other sinks that use this field only use it in case of (e)AC3 audio so the change has no effect on them.

Motivation and context

How has this been tested?

webOS 8, tried several different DTS format files

What is the effect on users?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@sundermann sundermann added Type: Improvement non-breaking change which improves existing functionality Component: Audio Platform: webOS v22 "P" labels Apr 14, 2024
@sundermann sundermann added this to the "P" 22.0 Alpha 1 milestone Apr 14, 2024
Copy link
Member

@fritsch fritsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - makes sense, especially as it's needed for a Sink.

@sundermann
Copy link
Contributor Author

One thing to mention is that for DTS:X support we need to have this information available. This is available from ffmpeg 6.1 as a profile hint so I'll leave that for later. This also applies for the eAC3 JOC case.

Copy link
Member

@fritsch fritsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Core changes are minimal. The changes to other components outside of WebOS are simply member variable name changes. All good.

@sundermann
Copy link
Contributor Author

Just one more small change moved setting m_frameSize so it's not updated all the time which is not necessary

@sundermann
Copy link
Contributor Author

Jenkins build this please

@sundermann sundermann merged commit 01ee1c5 into xbmc:master Apr 14, 2024
2 checks passed
@Noltari
Copy link

Noltari commented Apr 15, 2024

@sundermann I tested this yesterday and the DTS audio seems to have sync issues, which doesn't happen to me with AC3 passthrough.
I'm not sure if that's possible or maybe it's related to #24193...

@sundermann
Copy link
Contributor Author

Nothing more we can do in the sink with the limited API we have available now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Audio Platform: webOS Type: Improvement non-breaking change which improves existing functionality v22 "P"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants