Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Video] Fix for #25097 and requested updates from #24720 #25099

Merged
merged 1 commit into from
May 4, 2024

Conversation

78andyp
Copy link
Contributor

@78andyp 78andyp commented May 1, 2024

Description

This PR is twofold:

  1. It fixes the issue reported in Starting file playback with keyboard Enter button is broken in master #25097.

When play from here or automatically play next item are selected then a playlsit is generated.
If this was done through Video -> Files, on items that weren't yet scanned into the database then there was no VideoInfoTag and therefore p->GetVideoInfoTag()->m_basePath was actually empty.

This corrects that.

  1. Requested updates from devs

As detailed in 54a63d0

Motivation and context

How has this been tested?

Part 1 by @smp79 who kindly reported the original issue.

What is the effect on users?

Fix and code optimisation/clarity.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@78andyp 78andyp changed the title [Testing] Fix for #25097 [Video] Fix for #25097 and requested updates from #24720 May 1, 2024
xbmc/dialogs/GUIDialogSimpleMenu.cpp Outdated Show resolved Hide resolved
xbmc/windows/GUIMediaWindow.cpp Outdated Show resolved Hide resolved
xbmc/windows/GUIMediaWindow.cpp Outdated Show resolved Hide resolved
xbmc/windows/GUIMediaWindow.cpp Outdated Show resolved Hide resolved
xbmc/windows/GUIMediaWindow.cpp Outdated Show resolved Hide resolved
xbmc/windows/GUIMediaWindow.cpp Outdated Show resolved Hide resolved
addons/resource.language.en_gb/resources/strings.po Outdated Show resolved Hide resolved
@neo1973 neo1973 added Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality v22 "P" labels May 2, 2024
@neo1973 neo1973 added this to the "P" 22.0 Alpha 1 milestone May 2, 2024
@neo1973 neo1973 linked an issue May 2, 2024 that may be closed by this pull request
7 tasks
@78andyp 78andyp force-pushed the playlist_fix branch 2 times, most recently from 6a0f018 to 3dba96a Compare May 3, 2024 15:21
xbmc/windows/GUIMediaWindow.cpp Show resolved Hide resolved
xbmc/windows/GUIMediaWindow.cpp Outdated Show resolved Hide resolved
xbmc/windows/GUIMediaWindow.cpp Outdated Show resolved Hide resolved
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this looks good.

@ksooo
Copy link
Member

ksooo commented May 4, 2024

jenkins build this please

@enen92 enen92 merged commit db1f89b into xbmc:master May 4, 2024
2 checks passed
@78andyp 78andyp deleted the playlist_fix branch May 5, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality v22 "P"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting file playback with keyboard Enter button is broken in master
4 participants