-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Video] Fix for #25097 and requested updates from #24720 #25099
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ksooo
reviewed
May 1, 2024
7 tasks
6a0f018
to
3dba96a
Compare
ksooo
reviewed
May 3, 2024
ksooo
approved these changes
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, this looks good.
jenkins build this please |
enen92
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Fix
non-breaking change which fixes an issue
Type: Improvement
non-breaking change which improves existing functionality
v22 "P"
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is twofold:
When play from here or automatically play next item are selected then a playlsit is generated.
If this was done through Video -> Files, on items that weren't yet scanned into the database then there was no
VideoInfoTag
and thereforep->GetVideoInfoTag()->m_basePath
was actually empty.This corrects that.
As detailed in 54a63d0
Motivation and context
How has this been tested?
Part 1 by @smp79 who kindly reported the original issue.
What is the effect on users?
Fix and code optimisation/clarity.
Screenshots (if appropriate):
Types of change
Checklist: