[PVR] Timer settings dialog: Add client name to 'Any channel' value s… #25203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the values can be distinguished by the user.
ksooo
added
Type: Fix
phunkyfish
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o the values can be distinguished by the user.
When creating an epg-based reminder rule in a multi-client setup, the 'any channel' labels in timer settings dialog had all the same label, making it impossible to safely pick an entry for the intended client.
Thus, I consider this a fix not just an improvement.
This PR adds the full client name to the 'any channel' labels, if multiple clients are active.
Before:
After:
Runtime-tested on macOS and android, latest Kodi master.
@phunkyfish should be an easy one for a review.