New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protocol option 'seekable' for CurlFile (http/https). #2521
Conversation
What about ftp? You are changing behavior for other things than http. |
oh~, so, it's http/https only protocol option. nothing changed to ftp, check the code, it only make difference when seekable=false set in http/https protocol options. |
Seems like a useful options to have (for addons).... |
Ok. I missed how it was set to true before. Looks okey. |
as this will be handy for a number of add-on (official NASA add-on is one of them) can this also be implemented for use in .strm files ? |
Will work there too for any http stream. |
the only problem is that what the value of the option we preferred, 'seekable=false' or 'seekable=0' ? |
I prefer false/true, it's in line with the other stuff we do.... |
ok, then we go. |
oh, it maybe not, in ftp protocol we are using 0/1 value, wait me merge the ftp stuff first and then see. |
updated, finally we choose to use seekable=0, it simpler, and all other bool protocol options use 0/1, except the noshout one, but which is used by xbmc itself only. |
Add protocol option 'seekable' for CurlFile (http/https).
Can't we do both?: 0/false and 1/true? |
they are handled by manually compare, not by bool type, and it's new added, addons will known how to add and use it. one usage is good and make things unify. |
so addons can create the final url with 'seekable=0' url options to tell CurlFile certain stream is unseekable.