Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protocol option 'seekable' for CurlFile (http/https). #2521

Merged
merged 1 commit into from Apr 1, 2013

Conversation

ulion
Copy link
Contributor

@ulion ulion commented Apr 1, 2013

so addons can create the final url with 'seekable=0' url options to tell CurlFile certain stream is unseekable.

@elupus
Copy link
Contributor

elupus commented Apr 1, 2013

What about ftp? You are changing behavior for other things than http.

@ulion
Copy link
Contributor Author

ulion commented Apr 1, 2013

oh~, so, it's http/https only protocol option. nothing changed to ftp, check the code, it only make difference when seekable=false set in http/https protocol options.

@arnova
Copy link
Member

arnova commented Apr 1, 2013

Seems like a useful options to have (for addons)....

@elupus
Copy link
Contributor

elupus commented Apr 1, 2013

Ok. I missed how it was set to true before. Looks okey.

@jester-xbmc
Copy link

as this will be handy for a number of add-on (official NASA add-on is one of them) can this also be implemented for use in .strm files ?

@elupus
Copy link
Contributor

elupus commented Apr 1, 2013

Will work there too for any http stream.

@ulion
Copy link
Contributor Author

ulion commented Apr 1, 2013

the only problem is that what the value of the option we preferred, 'seekable=false' or 'seekable=0' ?
I wrote false just because the noshout using 'true'. but maybe 'seekable=0' is better?

@arnova
Copy link
Member

arnova commented Apr 1, 2013

I prefer false/true, it's in line with the other stuff we do....

@ulion
Copy link
Contributor Author

ulion commented Apr 1, 2013

ok, then we go.

@ulion
Copy link
Contributor Author

ulion commented Apr 1, 2013

oh, it maybe not, in ftp protocol we are using 0/1 value, wait me merge the ftp stuff first and then see.

@ulion
Copy link
Contributor Author

ulion commented Apr 1, 2013

updated, finally we choose to use seekable=0, it simpler, and all other bool protocol options use 0/1, except the noshout one, but which is used by xbmc itself only.

ulion added a commit that referenced this pull request Apr 1, 2013
Add protocol option 'seekable' for CurlFile (http/https).
@ulion ulion merged commit 7d6509b into xbmc:master Apr 1, 2013
@arnova
Copy link
Member

arnova commented Apr 1, 2013

Can't we do both?: 0/false and 1/true?

@ulion
Copy link
Contributor Author

ulion commented Apr 1, 2013

they are handled by manually compare, not by bool type, and it's new added, addons will known how to add and use it. one usage is good and make things unify.

@ulion ulion deleted the curl_protocol_option_seekable branch April 6, 2013 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants