Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPlayer: add setting for using VAAPI AVC #25240

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

smp79
Copy link
Contributor

@smp79 smp79 commented May 22, 2024

Description

This adds "Use AVC VAAPI" setting. I always thought it was already there but apparently it wasn't.

Motivation and context

Makes it possible to disable VAAPI hw acceleration for AVC.

How has this been tested?

Build and runtime tested on Intel TGL + LibreELEC.

Screenshots (if appropriate):

IMG_20240522_042635440

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • [ X] Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • [X ] My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Copy link
Contributor

@howie-f howie-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime tested. works.
i can disable ff-h264-vaapi (HW) and switch to ff-h264 (SW)

@howie-f howie-f added Type: Improvement non-breaking change which improves existing functionality Component: Settings v22 "P" labels Jun 17, 2024
@howie-f howie-f added this to the "P" 22.0 Alpha 1 milestone Jun 17, 2024
@howie-f howie-f merged commit 699334e into xbmc:master Jun 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Settings Component: Video Type: Improvement non-breaking change which improves existing functionality v22 "P"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants