[OMXPlayer] Frodo fixes #2575
Closed
[OMXPlayer] Frodo fixes #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a Pi, imageres and fanartres are set quite low (typically 512 and 720 or lower). So, when caching the artwork there is a resize step involved. The OMXImage jpeg decoder has the option to resize "for free". Unfortunately this currently only limits the resize to current GUI resolution, so there is often a second resize done by the ARM. This is very slow. The larger decoded image also requires more RAM. With fanartres=512, you currently get resize during decode of 1920x1080 to 1280x720 (gui res). Then before encode there is a resize to 910x512. The two stage resize reduces image quality. This fix takes a bit more care to include the imageres/fanartres resize during the decode. I needed to make the 16:9 check a little more lax to also detect a 16:9 image after it's been resized. I've gone for differs from 16:9 by 1%, rather than the existing exact match of 16:9.
I don't believe the lock=false call should ever be done unless caller already has lock
|
backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more fixes see frodo thread