[OSX] support system input method #2619
Conversation
|
move it to @davilla cause i'm not even used to the osx input methods (i mean even from the user perspective). |
|
if no regressions on win/linux for the 1st commit, ok to inject. |
|
updated, old version break screen keyboard, now fixed. |
|
Well i really tried to review that one. But i don't get the picture of it. I get that the editingstring is something temporarly which gets flushed out to the editstr at some point. And that the editingstring is highlighted or so. But all the diddle with the cursorpos and stuff - i can't grasp that just by looking at the code. Maybe @jmarshallnz wants to give it another look - or we just push it... At least it should compile fine from the looks on all platforms.[tm] |
|
A quick look suggests a more thorough review is needed. I will attempt to look at it this evening. |
| Character(action.GetUnicode()); | ||
| #endif |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Please get rid of all the debugging logging - we don't need more log spam than we already have. |
|
log removed, ifdef removed. |
|
It looks OK at this point. I'd need to see it in action to evaluate further, so feel free to merge and any refining can then be done later. |
|
change to use gui user message as suggested. |
[OSX] support system input method
This PR need #2522
osx user now can first press option+e then press key 'e' to input 'é' when using us keyboard layout(input method)
and support all osx system input methods