[SWIG] Sets defaultt -> default for keyword args #2767
Conversation
|
@jimfcarroll, would you consider this. |
|
I should explain :) Currently the pydocs list default as the keyword. For obvious reasons default is not allowed as a parameter, so you used defaultt. But this is a poor keyword and I can't think of another word for this specific parameter. Plus changing could break some addons, though defaultt should have also. This patch simply renames defaultt -> default for the keyword only and now matches the pydocs. |
|
Is this PR ment to be tested by jenkins? |
|
no, i was hoping @jimfcarroll would comment. |
|
the jenkins message was an accident - please ignore it... |
|
Though there's no need for the temporary, it works. |
|
@jimfcarroll |
|
Really? There's code in the template in order to change the name of a single parameter somewhere in the code? IMO, leaving defaultt is much cleaner than having generic code modified to handle one off case. Why not just change the name to 'dflt' or something? |
No description provided.