Skip to content

Loading…

droid: fix launching android apps from favourites #2784

Merged
merged 1 commit into from

5 participants

@ronie
Team Kodi member

currently xbmc fails to run android apps from favourites.
it incorrectly uses PlayMedia() instead of StartAndroidActivity()
this commit fixes that.

untested! - i can't build for android myself.

@theuni theuni was assigned
@davilla

@theuni ? Looks ok to me.

@theuni
Team Kodi member

Looks fine assuming the formatting is correct.

@Montellese
Team Kodi member

@Tolriq: Does this require any adjustments/extensions in the Favourite stuff you added to JSON-RPC?

@Tolriq

I'd say yes to return those favourites too, but current code will just ignore them so not breaking things.

But we'll be facing the problem that there's no way to start those from JSON so don't know if it's pertinent to add support for them, specially since there's still no decision taken on the Delete part so remote won't be able to do anything.

@davilla

The ability to start random Android apps from JSON might be considered a security risk.

@davilla davilla merged commit 2174167 into xbmc:master
@mo123 mo123 referenced this pull request
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 24, 2013
  1. @ronie
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 0 deletions.
  1. +2 −0 xbmc/Favourites.cpp
View
2 xbmc/Favourites.cpp
@@ -157,6 +157,8 @@ CStdString CFavourites::GetExecutePath(const CFileItem *item, int contextWindow)
execute.Format("ActivateWindow(%i,%s)", contextWindow, StringUtils::Paramify(item->GetPath()).c_str());
else if (item->IsScript())
execute.Format("RunScript(%s)", StringUtils::Paramify(item->GetPath().Mid(9)).c_str());
+ else if (item->IsAndroidApp())
+ execute.Format("StartAndroidActivity(%s)", StringUtils::Paramify(item->GetPath().Mid(26)).c_str());
else // assume a media file
{
if (item->IsVideoDb() && item->HasVideoInfoTag())
Something went wrong with that request. Please try again.