droid: fix launching android apps from favourites #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@theuni ? Looks ok to me. |
|
Looks fine assuming the formatting is correct. |
|
@Tolriq: Does this require any adjustments/extensions in the Favourite stuff you added to JSON-RPC? |
|
I'd say yes to return those favourites too, but current code will just ignore them so not breaking things. But we'll be facing the problem that there's no way to start those from JSON so don't know if it's pertinent to add support for them, specially since there's still no decision taken on the Delete part so remote won't be able to do anything. |
|
The ability to start random Android apps from JSON might be considered a security risk. |
davilla
added a commit
that referenced
this pull request
Jun 1, 2013
droid: fix launching android apps from favourites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently xbmc fails to run android apps from favourites.
it incorrectly uses PlayMedia() instead of StartAndroidActivity()
this commit fixes that.
untested! - i can't build for android myself.