droid: fix launching android apps from favourites #2784

Merged
merged 1 commit into from Jun 1, 2013

Conversation

Projects
None yet
5 participants
@ronie
Member

ronie commented May 24, 2013

currently xbmc fails to run android apps from favourites.
it incorrectly uses PlayMedia() instead of StartAndroidActivity()
this commit fixes that.

untested! - i can't build for android myself.

@ghost ghost assigned theuni May 24, 2013

@davilla

This comment has been minimized.

Show comment
Hide comment
@davilla

davilla May 25, 2013

Contributor

@theuni ? Looks ok to me.

Contributor

davilla commented May 25, 2013

@theuni ? Looks ok to me.

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni May 25, 2013

Member

Looks fine assuming the formatting is correct.

Member

theuni commented May 25, 2013

Looks fine assuming the formatting is correct.

@Montellese

This comment has been minimized.

Show comment
Hide comment
@Montellese

Montellese May 28, 2013

Member

@Tolriq: Does this require any adjustments/extensions in the Favourite stuff you added to JSON-RPC?

Member

Montellese commented May 28, 2013

@Tolriq: Does this require any adjustments/extensions in the Favourite stuff you added to JSON-RPC?

@Tolriq

This comment has been minimized.

Show comment
Hide comment
@Tolriq

Tolriq May 28, 2013

Contributor

I'd say yes to return those favourites too, but current code will just ignore them so not breaking things.

But we'll be facing the problem that there's no way to start those from JSON so don't know if it's pertinent to add support for them, specially since there's still no decision taken on the Delete part so remote won't be able to do anything.

Contributor

Tolriq commented May 28, 2013

I'd say yes to return those favourites too, but current code will just ignore them so not breaking things.

But we'll be facing the problem that there's no way to start those from JSON so don't know if it's pertinent to add support for them, specially since there's still no decision taken on the Delete part so remote won't be able to do anything.

@davilla

This comment has been minimized.

Show comment
Hide comment
@davilla

davilla May 28, 2013

Contributor

The ability to start random Android apps from JSON might be considered a security risk.

Contributor

davilla commented May 28, 2013

The ability to start random Android apps from JSON might be considered a security risk.

davilla added a commit that referenced this pull request Jun 1, 2013

Merge pull request #2784 from ronie/androidapp
droid: fix launching android apps from favourites

@davilla davilla merged commit 2174167 into xbmc:master Jun 1, 2013

@ronie ronie deleted the ronie:androidapp branch Feb 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment