pvr: Pass selected item to menu hooks #2812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it is not possible to retrieve any information about the selected item in the addon's menu hook callback. Therefore menu hooks can only trigger actions per category, but not per item. This patch removes this limitation by extending CallMenuHook with an item parameter representing the type (PVR_MENUHOOK_CAT) and the data of the currently selected item. The type PVR_MENUHOOK_UNKNOWN indicates that no selection is available (as for settings hooks).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to retrieve any information about the
selected item in the addon's menu hook callback. Therefore menu
hooks can only trigger actions per category, but not per item.
This patch removes this limitation by extending CallMenuHook with
an item parameter representing the type (PVR_MENUHOOK_CAT) and the
data of the currently selected item. The type PVR_MENUHOOK_UNKNOWN
indicates that no selection is available (as for settings hooks).
Needs PVR API version bump and the corresponding changes in the addon's repository.
I hope this can be considered, since it allows to call some backend specific functionalities.