Abitily to use host system language/regional settings #2831

Karlson2k · 2013-06-05T11:01:55Z

I believe that any serious program must use system-wide settings, like language/regional settings. No such settings is used in XBMC for now.
That might confuse inexperienced users that are forced to find and change language after first XBMC installation. Problem is even worse if user doesn't know English.
This PR add support for using host system regional settings as default XBMC language/regional settings. User is still free to change XBMC regional settings, default settings are used only at first XBMC run and after XBMC settings reset.
Code is trying to find best matching language and region. If no suitable language is found, code defaulting to "English", If system region is not available in XBMC, than language default region is used.

Code in this PR detects host system setting on Win32, Linux, FreeBSD and Android (by @Montellese) platforms, but platform support can be easily extended.

xbmc/LangInfo.cpp

-    SetCurrentRegion(strName);
+    if (m_globalObject)
+    {
+      const CStdString& strName=CSettings::Get().GetString("locale.country");


ace20022 · 2013-06-05T11:36:59Z

Just had a brief look, great idea. There are quite long parameter lists, maybe a struct could be useful.

Fneufneu · 2013-06-05T13:59:31Z

FreeBSD work exactly like Linux here

Karlson2k · 2013-06-09T01:17:26Z

@jmarshallnz Rewritten according to your comments

Karlson2k · 2013-06-11T11:16:39Z

@jmarshallnz Should I move CLanguageTag to separate .h/.cpp?

jenkins4xbmc · 2013-06-16T19:41:59Z

Is this PR ment to be tested by jenkins?

Karlson2k · 2013-06-16T23:41:07Z

jenkins test this please

garbear · 2013-06-16T23:53:20Z

after several frustrating false-starts, the new command has been changed to "jenkins test this, you annoying piece of crap"

Karlson2k · 2013-07-02T22:38:46Z

@jmarshallnz ?

jmarshallnz · 2013-07-06T23:20:57Z

jenkins build this please

jmarshallnz · 2013-07-06T23:36:18Z

Ideally the extra class would move to another file, but I'm aware this will have build implications, so could be done in another round so that this gets in and gets tested.

Memphiz · 2013-07-07T10:40:02Z

@jmarshallnz BTW - the jenkins trigger doesn't Need to be a single comment - you can just add it somewhere in a comment and it will trigger aswell :)

Memphiz · 2013-07-07T10:44:19Z

Build failed on ios because the pr is not rebased to Master (and has outdated jenkins scripts) - on droid it failed because of something Else i have Seen before but can't remember what (maybe rebase Fixed that one too)

Karlson2k · 2013-07-08T11:48:01Z

@jmarshallnz Done.
jenkins build this please

MartijnKaijser · 2013-07-08T11:52:14Z

Only team members can initiate a build.

jenkins build this please

Karlson2k · 2013-07-08T13:12:48Z

Note to Android devs:
to add android support you just need to set sysLang at Karlson2k@ee7af92#L0R620 to result of java function Locale.getDefault().toString().

Montellese · 2013-07-10T06:57:28Z

Is this good to be merged? I volunteer to look at the android side over the weekend if this gets in during this merge window.

Karlson2k · 2013-07-10T07:32:52Z

@Montellese nice! Android support should be simple now.
Meantime could you ask jenkins to rebuild this with last commit?

Montellese · 2013-07-10T07:42:12Z

jenkins build this please

Montellese · 2013-07-11T17:52:19Z

You can get the top three commits from Montellese/xbmc@master...autoset_lang for android support.

The last commit can be squashed into your other commits. IMO it doesn't make sense to only do the "set default language" for specific platforms. Any platform not supporting it will return "English" anyway.

Maybe it makes sense to retrieve the default language returned from CLangInfo::GetAvailableDefaultLanguage() from the actual default value of the locale.language setting so "English" is not hardcoded.

Karlson2k · 2013-07-11T21:05:15Z

@Montellese Thanks for nice idea! And for android code too. :)

MartijnKaijser · 2013-07-23T08:34:41Z

jenkins build this please

@jmarshallnz / @Montellese
ok for next window?

Montellese · 2013-07-23T11:00:00Z

I haven't looked at the changes in detail but I tested it on win32 and it works and I implemented it on android and it works (TM). IMO it's a very valid and valuable addition as it's something I expect of almost every application I install.

xbmc/android/jni/Locale.cpp

@@ -0,0 +1,41 @@
+/*
+ *      Copyright (C) 2013 Team XBMC
+ *      http://www.xbmc.org


Montellese · 2013-07-30T09:23:27Z

Please squash your last cleanup commit into the proper commit.

Karlson2k · 2013-07-30T12:34:17Z

@Montellese done

theuni · 2013-07-31T10:14:42Z

@Montellese: beautifully done, thanks.

Though, AConfiguration_getCountry() and AConfiguration_getLanguage() might've been a bit easier ;)

@Karlson2k: Have you verified that asian/rtl languages have working default fonts? If a Chinese user runs XBMC and gets Chinese by default, it's crucial that they not see blocks.

Montellese · 2013-07-31T10:58:36Z

@theuni: yeah I considered those as well but it would have required changes to the rest of the parsing logic and it was a chance to look into your JNI refactoring and how it works now ;-)

…tic and public

…s and make it static

This is for case that capture group (subpattern) was skipped during RE match

…FC 5646) language tags

…ngs when checking for language

…m default language.

ace20022 · 2013-10-03T08:49:08Z

It's not yet ready for merge. I'm working on solution for languages scripts missing in base fonts.

Could you please open a separate pr with bug-fixes only? So we can merge them asap?

ace20022 · 2013-10-14T08:06:19Z

@Karlson2k Gentle reminder, could you please separate the bugfix(es)?

Karlson2k · 2013-10-14T08:12:59Z

@ace20022 Soon

MartijnKaijser · 2013-11-14T07:26:50Z

@jmarshallnz @t-nelson
Although merge window is closed I still think this would be potential good candidate for user friendliness. Thoughts?

Karlson2k · 2013-11-14T11:56:37Z

@MartijnKaijser, this PR is really good for users, but to merge it we need to implement detection of character presence in font. I know how to implement it, but this in turn may require to extend language .xml to include string with full alphabet.

xbmc/utils/LangCodeExpander.cpp

+
+bool CLanguageTag::operator!=(const CLanguageTag& other) const
+{
+  return !operator==(other);


MartijnKaijser · 2014-08-10T07:49:52Z

@Karlson2k Any progress on this?

Karlson2k · 2014-08-10T10:56:13Z

@MartijnKaijser This should be rebased, but before merging it some companion PR for fonts handling must be merged.

I'm thinking about implementing "fallback" font for missing chars. General idea: if some glyph is missing in current font, try to substitute it from "fallback" font defined in skin and, if missing in skin fallback font, substitute glyph from system "arial" font. @jmarshallnz What do you think?

jmarshallnz · 2014-08-11T03:03:05Z

@Karlson2k if it can be done easily, sure. I'm not sure how easy it is to get the information out into textlayout object which I think is where it will be needed.

topfs2 · 2014-08-11T17:12:31Z

Just from a quick glance at the discussion here, Isn't the font issue rather unrelated to this PR? I mean we had that problem if the user selected the language in the settings too?

Karlson2k · 2014-08-11T17:17:31Z

@topfs2 Font issue makes Kodi with this PR unusable on some systems if system default language alphabet is not present in default font.

topfs2 · 2014-08-11T20:15:43Z

But wouldn't that still happen if you pick that language in settings anyways?

Karlson2k · 2014-08-11T20:18:59Z

Of course. But in this case it will be much simpler to blindly switch it back.
If Kodi is started with only blanks and digits, it should be not so easy to open settings, find required setting and switch it to something readable.

da-anda · 2017-01-22T12:24:28Z

are there any interests in resurrecting this PR?

ace20022 reviewed Jun 5, 2013
View reviewed changes

xbmc/LangInfo.cpp

SetCurrentRegion(strName);

if (m_globalObject)

{

const CStdString& strName=CSettings::Get().GetString("locale.country");

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

MartijnKaijser reviewed Jul 26, 2013
View reviewed changes

xbmc/android/jni/Locale.cpp

@@ -0,0 +1,41 @@

/*

* Copyright (C) 2013 Team XBMC

* http://www.xbmc.org

This comment was marked as spam.

Sign in to view

ghost assigned Montellese Jul 30, 2013

Karlson2k added 13 commits August 6, 2013 22:40

LangCodeExpander: Use std::string for LookupInDb, make LookupInDb sta…

bf5ac4a

…tic and public

LangCodeExpander: use std::string for ConvertLinuxToWindowsRegionCode…

fa3035d

…s and make it static

RegExp: don't use negative position for substring.

01a660f

This is for case that capture group (subpattern) was skipped during RE match

RegExp: Add GetNamedSubPatternNumber function

686aab0

LangCodeExpander: Add new class CLanguageTag for processing BCP 47 (R…

58551b8

…FC 5646) language tags

LangInfo: remove usage of "g_langInfo" from non-static functions

7be6c4b

LangInfo: refactoring for test load language

db23dc1

LangCodeExpander: side bugfix: don't try to set global regional setti…

dd1ba02

…ngs when checking for language

LangInfo: add ability to detect available language suitable for syste…

27ad0a9

…m default language.

Settings: Set default language and region to host system defaults

b33a5bc

[Linux/FreeBSD] Add support for detection of system language settings

0cc1614

[droid] add CJNILocale class

eb9f218

[droid] retrieve system default language

11592e2

Rawk reviewed Nov 27, 2013
View reviewed changes

Paxxi mentioned this pull request Jan 12, 2015

[RFC] replace iconv and fribidi with icu library #5634

Closed

MartijnKaijser removed this from the Pending for inclusion milestone Jun 14, 2015

MartijnKaijser closed this Feb 18, 2017

Abitily to use host system language/regional settings #2831

Abitily to use host system language/regional settings #2831

Conversation

Karlson2k commented Jun 5, 2013

This comment was marked as spam.

This comment was marked as spam.

ace20022 commented Jun 5, 2013

Fneufneu commented Jun 5, 2013

Karlson2k commented Jun 9, 2013

Karlson2k commented Jun 11, 2013

jenkins4xbmc commented Jun 16, 2013

Karlson2k commented Jun 16, 2013

garbear commented Jun 16, 2013

Karlson2k commented Jul 2, 2013

jmarshallnz commented Jul 6, 2013

jmarshallnz commented Jul 6, 2013

Memphiz commented Jul 7, 2013

Memphiz commented Jul 7, 2013

Karlson2k commented Jul 8, 2013

MartijnKaijser commented Jul 8, 2013

Karlson2k commented Jul 8, 2013

Montellese commented Jul 10, 2013

Karlson2k commented Jul 10, 2013

Montellese commented Jul 10, 2013

Montellese commented Jul 11, 2013

Karlson2k commented Jul 11, 2013

MartijnKaijser commented Jul 23, 2013

Montellese commented Jul 23, 2013

This comment was marked as spam.

Montellese commented Jul 30, 2013

Karlson2k commented Jul 30, 2013

theuni commented Jul 31, 2013

Montellese commented Jul 31, 2013

ace20022 commented Oct 3, 2013

ace20022 commented Oct 14, 2013

Karlson2k commented Oct 14, 2013

MartijnKaijser commented Nov 14, 2013

Karlson2k commented Nov 14, 2013

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

MartijnKaijser commented Aug 10, 2014

Karlson2k commented Aug 10, 2014

jmarshallnz commented Aug 11, 2014

topfs2 commented Aug 11, 2014

Karlson2k commented Aug 11, 2014

topfs2 commented Aug 11, 2014

Karlson2k commented Aug 11, 2014

da-anda commented Jan 22, 2017