pvr: win32: Make sure that the addon libs define TARGET_WINDOWS #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, _WIN32 has been replaced by TARGET_WINDOWS. Since this is a project specific define and not a system variable, we have to make sure that the PVR addon libs define this in their project configuration. Otherwise the libs won't export any symbols and the PVR addons cannot be loaded.
|
i'll update the ref to the add-ons themselves later today |
opdenkamp
pushed a commit
that referenced
this pull request
Jun 9, 2013
pvr: win32: Make sure that the addon libs define TARGET_WINDOWS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, _WIN32 has been replaced by TARGET_WINDOWS. Since this is a project specific define and not a system variable, we have to make sure that the PVR addon libs define this in their project configuration. Otherwise the libs won't export any symbols and the PVR addons cannot be loaded.