Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 4K resolution info for skinners #3122

Merged
merged 1 commit into from Sep 1, 2013
Merged

Conversation

ronie
Copy link
Member

@ronie ronie commented Aug 18, 2013

add '4K' to the list of possible values that ListItem.VideoResolution and VideoPlayer.VideoResolution can return.

@da-anda
Copy link
Member

da-anda commented Aug 28, 2013

this will also flag FullSBS / FullOU movies (stereoscopic) as 4K which is wrong

@MartijnKaijser
Copy link
Member

perhaps add 3D flag when certain resolutions are detected too? would make couple of users happy

@da-anda
Copy link
Member

da-anda commented Aug 28, 2013

@MartijnKaijser sure, this is on my roadmap. But if anybody else wants to give it a try, go ahead.

eidt: ok, let's consider this PR as correct as long as we don't have 3D flags/detection.

@MartijnKaijser
Copy link
Member

should be "relatively easy" by detecting if it matches known FullSBS / FullOU resolutions and putting up a 3D flag for it instead of a HD one?
should fit right in this piece of code

@da-anda
Copy link
Member

da-anda commented Aug 28, 2013

well, 3D flag is not only resolution depending. In case of FullSBS/OU you can detect it by resolution, but not for HalfSBS/OU, so we need some additional stream info/flag. This info is available inside DVDplayers stream details, but I'm not sure if it's also available here (not really familiar with this part of the code). Need to check. But let's not get too OT here and discuss it in it's own PR/forum.

MartijnKaijser added a commit that referenced this pull request Sep 1, 2013
add 4K resolution info for skinners
@MartijnKaijser MartijnKaijser merged commit 7f79eef into xbmc:master Sep 1, 2013
@ronie ronie deleted the 4K-lovers branch February 26, 2016 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature non-breaking change which adds functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants