ApplicationPlayer: Sanitize ClosePlayer() and SetPlaySpeed() #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me. |
fritsch
added a commit
that referenced
this pull request
Sep 6, 2013
ApplicationPlayer: Sanitize ClosePlayer() and SetPlaySpeed()
|
sweet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #2896, there was a 4/5 chance for a deadlock in CApplicationPlayer::GetInternal() when stopping video playback if a Python addon constantly polled the HasVideo bools.
When sanitizing SetPlaySpeed() and most importantly ClosePlayer() to also use the shared lock, the problem is gone.
Thanks to @t-nelson for the right hints and pointers to get this fixed!