pvr: display timeshift information to user #3319
Conversation
FernetMenta
commented
Sep 23, 2013
FernetMenta
commented
- add required functions to the api
- actual playing time is used for progress bar
- would be nice if this information could be added to skins, maybe as an additional progress bar plus the values
- corresponding pr to addons repo will follow
ghost
assigned 
|
do we need an additional progress bar for it as you wrote in the PR description? We already can indicate the buffer status e.g. on web-streams and we could use the same for the timeshift buffer I think. |
| if (GetPlayingClient(client)) | ||
| { | ||
| return client->GetPlayingTime(); | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
there has been a discussion on the forum: http://forum.xbmc.org/showthread.php?tid=151970 |
|
I use MediaPortal every day for watching TV, so I know it very well (I won't/can't switch to XBMC for LiveTV until certain issues in XBMC and the addon I use are resolved). |
| @@ -576,6 +576,22 @@ | |||
| void SetSpeed(int speed); | |||
|
|
|||
| /*! | |||
| * Get actual playing time from addon. With timeshift enabled this is | |||
| * different to live. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
yeep this will be good, like also good without stop watching back to actual time of LiveTV, for now we must stop and play this channel again :/ or switch and back. If we watch Timeshift - second presed Play button should back inmiditly to LiveTV |
|
Hi, no way to implement these new functions with addons does'nt handle demuxing. Time or frame info are handle by internal demuxer (ffmpeg). Could be an other way to manage it in XBMC itself ? |
|
that would have to be handled differently because those use file operations. |
|
In any case this must be handled by the addons/backends. XBMC itself knows nothing about the timeshift buffers or the offset to live. |
|
I thought it was possible using pts of stream and epg start time. Else to provide time info i need to ask from the backend the number of frames already written and keep in a map at regular time. It is ugly and i don't know if all backend could provide it. Percentage could easily be provided, but there is not really related to the duration. |
|
feel free to create a PR with an implementation of it :) |
|
@opdenkamp @FernetMenta , yes addon can provide "GetBufferTimeStart" and "GetBufferTimeEnd". But "GetPlayingTime" could be provided by player itself and so avoid ugly code for addon don't handle demuxing. I thought using the start time and first PTS of live playback and current PTS. But it is possible only if XBMC can handle the PTS. |
|
player can,t handle this because it does not know the offset between pts and current time. If you want player to display actual time, this has to implemented by the InputStream classes (which call the methods implemented here) |
|
@FernetMenta , Thanks. I will have a look |
|
replaced by #3604 |
|
Please guys looks on my proposition of timeshift bar i skin - thanks |
|
@piotrasd, if you don't have patches, keep it on the forum. Every github |
