pvr: gui improvements for live tv section #3387

xhaggi · 2013-10-06T18:15:12Z

This PR changes the way how to access the live tv channels (tv / radio) and channel groups within the gui. The channels (tv / radio) are populate into the same control list, so for skinners it's easier to integrate the channel view.
It's possible switching between the channel types (tv / radio) via a new control button.
To access the channel groups i integrated a select dialog which contains all groups. This is also accessible via a new control button.
The selected group is now also used for the EPG view, so you can easily switching between groups while you stay in epg view.

The needed skin changes are in a second commit.

CharlieMarshall · 2013-10-06T19:53:05Z

While I'm not in a position to remark on your code. I just tried this and It works great for me. I have been wanting something like this for a while. My only remark would be I would prefer if it performed like the "Channels" & "EPG" ie not a pop up menu but it displays the group name next to group ie "Group: All" and hitting enter changes to the next one, don't know how it would handle long group names, could the text there scroll? I realise this might not suit everyone so maybe an option on the LiveTV settings page to specify how it works.

xhaggi · 2013-10-06T20:19:29Z

The select dialog has the best usability for all situations, having long group names and if you use many groups it gives you a better overview and you can switch direcly to a bottom group.

xbmc/pvr/windows/GUIWindowPVR.cpp

+    {
+      return OpenGroupDialogSelect();
+    }
+    else {


jmarshallnz · 2013-10-06T20:30:03Z

Trivials noted. @opdenkamp for full review.

@da-anda: Perhaps you could comment on the UI?

dhead666 · 2013-10-07T07:35:13Z

I hope this ok to add here this remark.
Worth to mention this will remove a "hidden" remote mapping feature.

Currently I've got on my remote dedicated TV and Radio buttons which globally set to open MyPVR window with TV or Radio visible.
On MyPVR window there is another mapping in which the TV and Radio buttons are set to toggle the groups with just one button press.

For TV is Control.Message(32, click)
For Radio is Control.Message(33, click)

So maybe add NextChannelGroup action as the one in PVROSDChannels windows so this feature will not be lost.

xhaggi · 2013-10-07T07:45:36Z

@dhead666 Thank you for your comment, but this is user-specific stuff.
Still it would be useful to integrate the actions, so that skinners can benefit from.

opdenkamp · 2013-10-07T08:32:44Z

I'll review this one (and any other PVR related PR) tonight or tomorrow
evening.

On 10/07/2013 09:45 AM, Sascha Woo wrote:

@dhead666 https://github.com/dhead666 Thank you for your comment,
but this is user-specific stuff.
Still it would be useful to integrate the actions, so that skinners
can benefit from.

—
Reply to this email directly or view it on GitHub
#3387 (comment).

da-anda · 2013-10-07T09:29:18Z

btw - what happened to the rework/split of the PVR windows @pieh was working on?

ronie · 2013-10-07T21:17:08Z

having to toggle between the tv and radio listings through some select dialog doesn't seem very intuitive to me.
i'd rather keep those sections separate, as they currently are.
i'm fine with the group selection functionality.

would it be possible to handle it like this, with separate tv and radio buttons on the side menu:

TV: All
Radio: All

clicking either of those buttons would bring up the group selection dialog.

xhaggi · 2013-10-07T21:46:40Z

@ronie no select dialog to change the channel type, just click on the control in the media menu (it toggles between tv and radio).

I decided to implement this, because there is no different between tv and radio channels.

now using the epg depends on the selected type (before you can't use radio epg without playing a radio channel)
only one channel list for tv and radio, so that's easier to integrate for skinners

And to be honest, the handling is the same.

da-anda · 2013-10-07T22:42:58Z

while you're at it, can you hide radio related options in case there are no radio channels? Can also be done as seperate PR to not hold this one back.

edit: one thing that I also don't like in the screenshot is that the user doens't know/see that "Groups" is supposed to be clickable and change something. Maybe better name it "Group: [Name of group]" or "change channel group" or something like that

xhaggi · 2013-10-08T05:49:57Z

@da-anda sure both is possible. I will check if it's easy to hide the radio stuff.

I don't use "Group: [Name of group]" as label for the control because of long group names, but you're right, so i will change it.

something else that still bothers me (not only me) that the controls (channels, EPG) immediately activate the corresponding window. This creates an unsightly behaviour, for example if you want to switch to timers.
Now i think we can use click to activate the window and if it's active cycle through the view options e.g. on guide window (timeline, channel ..)

xhaggi · 2013-10-08T06:12:25Z

xhaggi · 2013-10-09T19:24:33Z

ahh ... i found some issues .. let you know if it's ready for review

xhaggi · 2013-10-09T21:10:48Z

fixed, reorganized and rebased .. i added an additional commit which change the behaviour for the control buttons.
now you have to click the button to change the corresponding window (channels, guide, recordings etc.) and it cycles through the view types (e.g. timeline, now, next, ..) if the window is active.

ronie · 2013-10-09T22:07:44Z

@xhaggi thanx for addressing my unfounded concerns :-)

the confluence changes are ok with me. please squash those.

i'm not too sure about the focus to click change. what's the reason you decided to alter it?
it's quite common in the skin that the content shown changes on the focus of a button,
eg. weather window and all of the settings windows...
to keep a unified experience in the skin, it might be better to leave it like that?

xhaggi · 2013-10-10T07:08:17Z

@ronie I have made these changes partly because all view options in the sidebar (video, music, pictures) are triggered by click and the more important thing for me todo this are the unsightly behaviour while switching from tv to recordings and back.

Let me explain it in detail:
Before these changes, if you stay in TV channels in the sidebar and want to switch to timers you have to move through the radio window, the guide window, the recording window and all windows pops up. if you have 100+ channels in the default group the epg needs 1-2 seconds for loading, so you stuck a bit.

okay this is the first reason. The second is more skin related. Now it is more flexible because you can reorder the button controls without thinking about in which direction the user navigate through (e.g. place the channel group selection button on top and than followed by channels, epg, etc.).
After reordering it's possible if you stay in epg view and want to change the channel group, just open the sidebar go to the channel group button (over the channels button, nothing happens!!), switch the group and close the sidebar and you will already stay in epg view.

and please at least try it ;)

opdenkamp · 2013-10-13T08:07:04Z

eeh you removed radio. please put it back. will look at the rest asap and comment, but that just caught my attention when i was clicking through the forum threads :)

xhaggi · 2013-10-13T08:40:51Z

@opdenkamp i didn't removed radio, i only changed the way you access the radio channels (toggle between tv/radio channel types). this relates to the fake that you can't access the radio epg with the current implementation without playing a radio channel.
let me know what i should put back?

piotrasd · 2013-10-13T08:47:33Z

@xhaggi please test this skin (LiveTV section) - and maybe you can something port to confluence ;)
https://copy.com/byigdNDQOidBoqyt

@xhaggi PS. sorry i forget when i answer on email i just comment - this commit

opdenkamp · 2013-10-13T09:54:58Z

hmm okay, well in my opinion radio should not be "hidden" but be accessible directly from the main window, since it's one of the primary functions of pvr.

xhaggi · 2013-10-13T10:05:17Z

@piotrasd please stop comment on this PR, use the forum instead.

xhaggi · 2013-10-13T10:13:59Z

@opdenkamp if you know you can toggle between tv/radio there is no need for an extra radio button, but if you think that's a must have i can add back the button. I my opinion it's totally enough if you can toggle between with one button ;)

opdenkamp · 2013-10-13T10:17:31Z

I've just discussed it with ronie (yay for devcon :)), and we both think that the radio item should be there instead of toggling. thanks

xhaggi · 2013-10-13T10:25:47Z

okay i will re-add the button ;)

xhaggi · 2013-10-21T05:20:58Z

@opdenkamp you wrote:
so with the current code, what you're asking is not possible (again, properly) and TV and radio are primary functions and channel groups are not. So both TV and radio must be visible in the list, and not be a switch (discussed it with ronie, who is now the confluence boss ;-))

could you tell me exactly how you are imagining it, splitting up the various views and separate window for tv and radio?

opdenkamp · 2013-10-21T09:04:12Z

well it would have to be split up in code, and be implemented like all the other windows instead of trying to handle it inside the GUIWindowPVR instance, and both TV and radio should be made separate entries in the home screen, instead of having both TV and radio under live tv

xhaggi · 2013-10-21T15:03:37Z

well, that's what I thought almost ;) .. what about recordings, it's the only part which is same for both tv and radio?

@opdenkamp i asked all this, because if this is the desired solution i will change this PR.

xhaggi · 2013-10-25T11:07:57Z

@opdenkamp let me know if I should change this

opdenkamp · 2013-10-28T18:19:16Z

we can just send them to the same (new) recordings window, and/or add a field to the api to flag whether a recording is radio or tv

…the mavericks compile patch on the top

* tv/radio channels were merged into one list * channel type switching (tv/radio) * adds a new selection dialog for channel groups

ACTION_NEXT_CHANNELGROUP

This adds a new label control for output the guide type (timeline, channel etc.), so that the group label control holds the channel group name in epg view.

This adds the ability to use built-in function ActivateWindow() with addition [dir] parameter to open a specified pvr window. Valid values: "tv", "radio", "guide", "recordings", "timers", "search"

xhaggi · 2013-11-01T09:59:41Z

okay.. I'll deal with it when I have some more time

xhaggi · 2013-11-06T19:40:28Z

move to #3585

piotrasd · 2013-11-09T19:29:28Z

@xhaggi Hi please look at my proposition of progress bar of timeshift
http://forum.xbmc.org/showthread.php?tid=177613 Thanks

t-nelson · 2013-11-09T19:45:19Z

@piotrasd, and again...

jmarshallnz reviewed Oct 6, 2013
View reviewed changes

xbmc/pvr/windows/GUIWindowPVR.cpp

{

return OpenGroupDialogSelect();

}

else {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

ghost assigned opdenkamp Oct 7, 2013

Memphiz and others added 17 commits October 30, 2013 17:30

[depends] - bump libsdl-native and libsdl (target) to 1.2.15 and add …

3b1bf61

…the mavericks compile patch on the top

pvr: improve handling in live tv gui

ead1876

* tv/radio channels were merged into one list * channel type switching (tv/radio) * adds a new selection dialog for channel groups

pvr: adds action ACTION_PREVIOUS_CHANNELGROUP and

682559c

ACTION_NEXT_CHANNELGROUP

cosmetics: comments and whitespaces

51eff8c

pvr: adds label control for selected type of epg

f2a3a3a

This adds a new label control for output the guide type (timeline, channel etc.), so that the group label control holds the channel group name in epg view.

pvr: observe channel group changes in guide window

aeee3a8

pvr: change control label for group selection to Group: [Name of group]

34cb7df

cosmetics: rename CONTROL_BTNCHANNEL_TYPE to CONTROL_BTNCHANNELS

512797c

pvr: adds message parameter to activate specific pvr window

418b831

This adds the ability to use built-in function ActivateWindow() with addition [dir] parameter to open a specified pvr window. Valid values: "tv", "radio", "guide", "recordings", "timers", "search"

pvr: use click instead of focus for controls

9c1a9e5

confluence: adds changes for live tv section

2c19996

confluence: use new label control for output type of epg

cc10b82

confluence: prevents opening sidebar on init (set defaultcontrol to 50)

b1ded4f

confluence: removes the labels of controls as they are set dynamicly

e0b7a69

confluence: use ActivateWindow() to open pvr related windows

4d2c1cf

pvr: re-add tv and radio button controls

13fe2f4

confluence: re-add tv and radio button controls

b9fe820

fix: null-check if pvr not enabled

c9200f8

xhaggi mentioned this pull request Nov 6, 2013

[pvr] Separate windows for TV and Radio #3585

Closed

xhaggi closed this Nov 6, 2013

xhaggi deleted the pvr branch July 17, 2014 18:22

pvr: gui improvements for live tv section #3387

pvr: gui improvements for live tv section #3387

Conversation

xhaggi commented Oct 6, 2013

CharlieMarshall commented Oct 6, 2013

xhaggi commented Oct 6, 2013

This comment was marked as spam.

This comment was marked as spam.

jmarshallnz commented Oct 6, 2013

dhead666 commented Oct 7, 2013

xhaggi commented Oct 7, 2013

opdenkamp commented Oct 7, 2013

da-anda commented Oct 7, 2013

ronie commented Oct 7, 2013

xhaggi commented Oct 7, 2013

da-anda commented Oct 7, 2013

xhaggi commented Oct 8, 2013

xhaggi commented Oct 8, 2013

xhaggi commented Oct 9, 2013

xhaggi commented Oct 9, 2013

ronie commented Oct 9, 2013

xhaggi commented Oct 10, 2013

opdenkamp commented Oct 13, 2013

xhaggi commented Oct 13, 2013

piotrasd commented Oct 13, 2013

opdenkamp commented Oct 13, 2013

xhaggi commented Oct 13, 2013

xhaggi commented Oct 13, 2013

opdenkamp commented Oct 13, 2013

xhaggi commented Oct 13, 2013

xhaggi commented Oct 21, 2013

opdenkamp commented Oct 21, 2013

xhaggi commented Oct 21, 2013

xhaggi commented Oct 25, 2013

opdenkamp commented Oct 28, 2013

xhaggi commented Nov 1, 2013

xhaggi commented Nov 6, 2013

piotrasd commented Nov 9, 2013

t-nelson commented Nov 9, 2013